Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(commonTests): restore disabled focus target testing for non-"none" focus targets #7235

Merged
merged 1 commit into from
Jun 27, 2023
Merged

test(commonTests): restore disabled focus target testing for non-"none" focus targets #7235

merged 1 commit into from
Jun 27, 2023

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco requested a review from Elijbet June 27, 2023 19:58
@jcfranco jcfranco requested a review from a team as a code owner June 27, 2023 19:58
@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Jun 27, 2023
@jcfranco jcfranco mentioned this pull request Jun 27, 2023
Merged
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 27, 2023
@jcfranco jcfranco merged commit 52351c4 into master Jun 27, 2023
@jcfranco jcfranco deleted the jcfranco/restore-disabled-test-assertions branch June 27, 2023 22:42
@github-actions github-actions bot added this to the 2023 July Priorities milestone Jun 27, 2023
benelan pushed a commit that referenced this pull request Jun 28, 2023
@jcfranco @benelan
test(commonTests): restore disabled focus target testing for non-"non…
3baf1d5 
…e" focus targets (#7235)

**Related Issue:** N/A

## Summary

Restores [assertions for tab/mouse focusing on disabled
components](https://github.com/Esri/calcite-components/blame/6777b06c5dbad5441ed651d676cd9562d79e6986/packages/calcite-components/src/tests/commonTests.ts#L1044-L1064)
removed in the [`disabled` test helper
refactor](#7089).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elijbet Elijbet Elijbet approved these changes

Assignees

@jcfranco jcfranco

Labels
skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2023 July Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @Elijbet