Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set design complete label conditionals #7206

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

geospatialem
Copy link
Member

Related Issue: n/a

Summary

Updates the design complete workflow for conditions, in the event labels are not present.

In this case, will continue to run if the design and/or 1 - assigned label(s) are not included in the issue. 🤖

@geospatialem geospatialem requested a review from a team as a code owner June 21, 2023 14:58
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jun 21, 2023
@geospatialem geospatialem added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 21, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡🤖⚡

name: "design"
});
} catch(err) {
console.log(err);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an additional message for context in addition to the caught error?

This also applies to the assigned label removal below.

...issueProps,
name: "design"
});
// Try to remove "Design" label
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this (and the comment below) need some info on why it may fail?

@geospatialem geospatialem merged commit 6777b06 into master Jun 21, 2023
@geospatialem geospatialem deleted the geospatialem/ci-design-complete-conditions branch June 21, 2023 20:42
@github-actions github-actions bot added this to the 2023 June patch priorities milestone Jun 21, 2023
benelan added a commit that referenced this pull request Jun 27, 2023
…issue-template-checkbox

* origin/master: (32 commits)
  ci: double build cc when publishing to workaround stencil types bug (#7227)
  build: bump package versions back to 1.5.0-next.5 (#7228)
  chore: release latest (#7144)
  ci: hardcode release version due to reverting feat (#7225)
  fix(tree-item): ensure expanded tree-item is displayed when expanded and made visible (#7216)
  ci(release-please): pin action version and allow manually running action (#7222)
  fix(input, input-number): allows numeric characters. (#7213)
  build(t9n): generate json file containing t9n values (#7214)
  chore: release next
  fix(combobox, dropdown, input-date-picker, input-time-picker, popover, tooltip): Prevent repositioning from affecting other floating components (#7178)
  build: update browserslist db (#7192)
  build: ignore node_modules and build outputs when watching for changes during stencil tests (#7209)
  test: set up `disabled` helper to run a test per use case (#7089)
  ci: set design complete label conditionals (#7206)
  chore: release next
  fix(list): update selectedItems property on all item selection changes (#7204)
  chore: fix sorting logic for t9nmanifest entries (#7203)
  fix(radio-button):  focuses first focusable radio-button element in group. (#7152)
  chore: release next
  fix(alert): update alert queue when an alert is removed from the DOM (#7189)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants