Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): No longer has incorrect border width #7160

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

macandcheese
Copy link
Contributor

@macandcheese macandcheese commented Jun 9, 2023

Related Issue: #6373

Summary

Fixes the "border gap" caused by the table rendered within List.

BEGIN_COMMIT_OVERRIDE
fix(list): No longer has incorrect border width
END_COMMIT_OVERRIDE

@macandcheese macandcheese requested a review from a team as a code owner June 9, 2023 15:33
@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 9, 2023
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 9, 2023
@macandcheese
Copy link
Contributor Author

cc @ashetland @SkyeSeitz there are some expected Chromatic changes as this will reduce the width of List by a few px.

@macandcheese macandcheese merged commit a810943 into master Jun 9, 2023
@macandcheese macandcheese deleted the macandcheese/6373-fix-list-border-style branch June 9, 2023 17:03
@macandcheese macandcheese changed the title fix(list): Improve border styling fix(list): No longer has incorrect border width Jun 9, 2023
macandcheese added a commit that referenced this pull request Jun 9, 2023
## Summary
Updates commit message in changelog cc @benelan
benelan added a commit that referenced this pull request Jun 15, 2023
…import

* origin/master: (30 commits)
  chore: release next
  fix(radio-button, radio-button-group): prevent emitting events when selecting a checked radio button (#7102)
  feat(list): Add slots for filter actions (#7148)
  chore: release next
  fix(tooltip): improve component timing (#7172)
  chore: release next
  fix(input-date-picker): Fix showing the placeholder when resetting the value (#7156)
  chore: release next
  fix(input,input-number): allow typing decimal separator in firefox for arabic locale (#7173)
  build(deps): Bump workbox-build from 6.5.4 to 7.0.0 (#7167)
  build(deps): Bump type-fest from 3.5.0 to 3.11.1 (#7169)
  build(deps): Bump chromatic from 6.17.4 to 6.19.5 (#7171)
  build(deps): Bump @floating-ui/dom from 1.2.9 to 1.3.0 in /packages/calcite-components (#7168)
  build(deps): Bump @esri/calcite-ui-icons from 3.22.9 to 3.23.1 in /packages/calcite-components (#7166)
  build: update browserslist db (#7162)
  ci(release-please): change PR title and ensure git tag consistency (#7153)
  docs(changelog): Update commit message for #7160 (#7161)
  chore: release next
  fix(list): Improve border styling (#7160)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants