Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] Improve border styling #6373

Closed
macandcheese opened this issue Jan 28, 2023 · 3 comments
Closed

[List] Improve border styling #6373

macandcheese opened this issue Jan 28, 2023 · 3 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jan 28, 2023

Actual Behavior

There are some cases where the transparent border on the List cause the List to:

  • not extend fully to the width of a container, creating a gap where background can be visible
  • when filter-enabled - scrolling items will show behind the sticky input bar for 1px

Group 8

Expected Behavior

The list extends to the full width of the parent container with no transparent borders. The list, when filter-enabled, does not allow the scrolled items to peek through behind the sticky input bar.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/oNMMjqJ?editors=1000

Reproduction Steps

  1. Open Codepen

Reproduction Version

1.0.3

Relevant Info

No response

Regression?

No response

Impact

No response

Esri team

Calcite (design)

@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 28, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Jan 28, 2023
@mjuniper
Copy link
Member

mjuniper commented Mar 30, 2023

Here's another reproduction of the issue where it does not extend to the width of its container: https://codepen.io/mjuniper/pen/VwGOzBB?editors=1100

I think the issue is that (at least for chrome) the user agent stylesheet has a rule like:

table {
  border-spacing: 2px;
}

@brittneytewks brittneytewks added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Apr 11, 2023
@brittneytewks brittneytewks added this to the 2023 July Priorities milestone Apr 11, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Apr 11, 2023
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 9, 2023
@macandcheese macandcheese self-assigned this Jun 9, 2023
macandcheese added a commit that referenced this issue Jun 9, 2023
**Related Issue:**
#6373

## Summary
Fixes the "border gap" caused by the table rendered within List.
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 9, 2023
@github-actions github-actions bot assigned geospatialem and unassigned macandcheese Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 26, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

5 participants