Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): Add slots for filter actions #7148

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 6, 2023

Related Issue: #6600

Summary

  • adds slot filter-actions-start.
  • adds slot filter-actions-end.
  • Uses calcite-stack internally for layout.
  • Adds story
  • Updates demo file

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jun 6, 2023
@driskull driskull marked this pull request as ready for review June 6, 2023 22:37
@driskull driskull requested a review from a team as a code owner June 6, 2023 22:37
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull requested a review from jcfranco June 14, 2023 23:49
# Conflicts:
#	packages/calcite-components/src/components/list/list.scss
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 15, 2023
@driskull driskull merged commit c9215c0 into master Jun 15, 2023
@driskull driskull deleted the dris0000/list-filter-actions branch June 15, 2023 18:34
@github-actions github-actions bot added this to the 2023 June patch priorities milestone Jun 15, 2023
@jcfranco
Copy link
Member

We may need to revert and install this later as it was installed into a patch-only milestone.

@driskull
Copy link
Member Author

ah sorry. I'll revert.

driskull added a commit that referenced this pull request Jun 15, 2023
@driskull driskull restored the dris0000/list-filter-actions branch June 15, 2023 19:19
benelan added a commit that referenced this pull request Jun 15, 2023
…import

* origin/master: (30 commits)
  chore: release next
  fix(radio-button, radio-button-group): prevent emitting events when selecting a checked radio button (#7102)
  feat(list): Add slots for filter actions (#7148)
  chore: release next
  fix(tooltip): improve component timing (#7172)
  chore: release next
  fix(input-date-picker): Fix showing the placeholder when resetting the value (#7156)
  chore: release next
  fix(input,input-number): allow typing decimal separator in firefox for arabic locale (#7173)
  build(deps): Bump workbox-build from 6.5.4 to 7.0.0 (#7167)
  build(deps): Bump type-fest from 3.5.0 to 3.11.1 (#7169)
  build(deps): Bump chromatic from 6.17.4 to 6.19.5 (#7171)
  build(deps): Bump @floating-ui/dom from 1.2.9 to 1.3.0 in /packages/calcite-components (#7168)
  build(deps): Bump @esri/calcite-ui-icons from 3.22.9 to 3.23.1 in /packages/calcite-components (#7166)
  build: update browserslist db (#7162)
  ci(release-please): change PR title and ensure git tag consistency (#7153)
  docs(changelog): Update commit message for #7160 (#7161)
  chore: release next
  fix(list): Improve border styling (#7160)
  chore: release next
  ...
driskull added a commit that referenced this pull request Jun 15, 2023
@driskull driskull deleted the dris0000/list-filter-actions branch June 15, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants