chore(icons): ensure UI icons follow naming convention #10292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
There were some quotes missing, but otherwise LGTM! I recommend shellcheck for catching linting issues like that.
.husky/pre-commit
Outdated
|
|
||
| STAGED_FILES=$(git diff --cached --name-only --diff-filter=ACM) | ||
|
|
||
| for file in $STAGED_FILES; do |
There was a problem hiding this comment.
Suggested change
| for file in $STAGED_FILES; do | |
| for file in "$STAGED_FILES"; do |
There was a problem hiding this comment.
Quoting this one gives me the following error:
Since you double quoted this, it will not word split, and the loop will only run once.
Thanks for the rec! Could you share your config? A fresh install didn't complain about quotes, so I might be missing something. |
arowles
approved these changes
Sep 13, 2024
benelan
added a commit
that referenced
this pull request
Sep 17, 2024
…estone-estimates * origin/dev: (997 commits) fix: correct non-standard filled icon names (#10309) fix(panel): initially closed panel should be hidden (#10308) chore(linting): automate tracking of custom Sass functions for stylelint (#10313) chore: tidy up demo pages (#10314) build(deps): update dependency dayjs to v1.11.13 (#10283) build(deps): update dependency jsdom to v24.1.3 (#10298) build(deps): update dependency husky to v9.1.6 (#10318) build(deps): update angular-cli monorepo to v18.2.4 (#10317) docs: update component READMEs (#10316) refactor(stylelint): change config to module format to enable more dynamic options (#10311) refactor: fixup typescript errors (#10295) build(deps): update dependency lint-staged to v15.2.10 (#10302) build(deps): update dependency focus-trap to v7.6.0 (#10281) build(deps): update dependency husky to v9.1.5 (#10297) chore: release next feat(checkbox): add component tokens (#10221) revert: "chore: set default page size for E2E tests (#10219)" (#10299) chore(icons): ensure UI icons follow naming convention (#10292) chore: release next feat: add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history (#10305) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
This updates our pre-commit hook to check SVG icons to make sure they follow the icon naming convention:
<iconName>-<size>.svg.<iconName>-<size>-f.svg.If an icon about to be committed does not match this format, the commit will fail and be canceled.