Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stylelint): change config to module format to enable more dynamic options #10311

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Sep 13, 2024

Related Issue: N/A

Summary

This change will give us more flexibility for sharing rule options and for more dynamic rule updates (e.g., #10188).

@jcfranco jcfranco requested a review from benelan as a code owner September 13, 2024 22:05
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Sep 13, 2024
@jcfranco jcfranco marked this pull request as draft September 13, 2024 22:07
@jcfranco jcfranco marked this pull request as ready for review September 13, 2024 23:05
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Sep 13, 2024
@jcfranco jcfranco requested a review from Elijbet September 13, 2024 23:06
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 78cc14f into dev Sep 16, 2024
13 checks passed
@jcfranco jcfranco deleted the jcfranco/change-styleling-config-to-module branch September 16, 2024 17:36
jcfranco added a commit that referenced this pull request Sep 16, 2024
…int (#10313)

**Related Issue:** #10188 

## Summary

This adds a script that tracks all custom Sass functions and updates the
metadata for Stylelint’s
[`function-no-unknown`](https://github.com/stylelint-scss/stylelint-scss/tree/master/src/rules/function-no-unknown)
rule, addressing workflow improvements as discussed in
#10188 (comment).

Our pre-commit hook will run this script if there is a staged Sass file
and will add any changes (if any).

**Note**: this depends on
#10311.

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan added a commit that referenced this pull request Sep 17, 2024
…estone-estimates

* origin/dev: (997 commits)
  fix: correct non-standard filled icon names (#10309)
  fix(panel): initially closed panel should be hidden (#10308)
  chore(linting): automate tracking of custom Sass functions for stylelint (#10313)
  chore: tidy up demo pages (#10314)
  build(deps): update dependency dayjs to v1.11.13 (#10283)
  build(deps): update dependency jsdom to v24.1.3 (#10298)
  build(deps): update dependency husky to v9.1.6 (#10318)
  build(deps): update angular-cli monorepo to v18.2.4 (#10317)
  docs: update component READMEs (#10316)
  refactor(stylelint): change config to module format to enable more dynamic options (#10311)
  refactor: fixup typescript errors (#10295)
  build(deps): update dependency lint-staged to v15.2.10 (#10302)
  build(deps): update dependency focus-trap to v7.6.0 (#10281)
  build(deps): update dependency husky to v9.1.5 (#10297)
  chore: release next
  feat(checkbox): add component tokens (#10221)
  revert: "chore: set default page size for E2E tests (#10219)" (#10299)
  chore(icons): ensure UI icons follow naming convention (#10292)
  chore: release next
  feat: add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history (#10305)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants