Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG-000170584 "layers-f" icon is not visible in Calcite Design System and getting a "layers16F is not a valid calcite-ui-icon name" error. #10312

Closed
geospatialem opened this issue Sep 13, 2024 · 6 comments
Closed

BUG-000170584 "layers-f" icon is not visible in Calcite Design System and getting a "layers16F is not a valid calcite-ui-icon name" error. #10312

geospatialem opened this issue Sep 13, 2024 · 6 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. Support Issues accepted from Esri Support.
Milestone
2024-09-30 - 2.13...

Comments

@geospatialem
Copy link
Member

"layers-f" icon is not visible in Calcite Design System and getting a "layers16F is not a valid calcite-ui-icon name" error.
Salesforce ID: BUG-000170584
Salesforce Submitter: Shlok Wagle
Salesforce Submit Date: 9/09/2024 3:29 PM
Salesforce Bug Type: Failure/Error
Salesforce Severity: Medium
Steps to Repro:

Steps to Reproduce:

  1. Go to the following documentation for svg icons provided by Calcite Design Systems.
  2. This particular link will show the "layers-f" icon. You will notice that this icon is not visible. https://developers.arcgis.com/calcite-design-system/icons/?icon=layers-f&query=layers-f
  3. Open dev tools > console. You will see a "layers16F" is not a valid calcite-ui-icon name error.
  4. If you click on other icons, they are visible. There only seems to be an issue with the "layers-f" icon.
  5. Tested by trying to add the same icon in a sample ArcGIS Maps SDK for JavaScript application and seeing a similar behavior.


Other Information:


Customer Data Specific Bug:

No


Repro Environment Details:

The layers-f icon in Calcite design system does not appear in a sample app or in the documentation icon sample.


Sample Environment Access Information:

https://developers.arcgis.com/calcite-design-system/icons/?icon=layers-f&query=layers-f


Development/PSIRT request?

No


Attached Files: No

Attached Video: No

Attached Logs: No

Attached Data: Yes

Reproducible in Latest Version: Yes


Repro Data: (n/a)
Work Around: (n/a)
Product: Calcite Design System
Functional Category: Calcite Design System
Client Platform: (n/a)
Version Found: 2.11.0
Planned Version Fixed: (n/a)
Comment: (n/a)
@geospatialem geospatialem added Support Issues accepted from Esri Support. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. regression Issues that are caused by changes in a release, but were working before that. labels Sep 13, 2024
@geospatialem
Copy link
Member Author

cc #10292

@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 13, 2024
@geospatialem geospatialem mentioned this issue Sep 17, 2024
Merged
@geospatialem geospatialem removed the 0 - new New issues that need assignment. label Sep 17, 2024
@geospatialem
Copy link
Member Author

geospatialem commented Sep 17, 2024 •
edited
Loading

Fix was shipped with #10309 and a chore was added to ensure the naming conventions are met. 🚀

@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Sep 19, 2024

@geospatialem I see the icon but the error in the console is still present, is this issue good to close out?

@geospatialem
Copy link
Member Author

I see the icon but the error in the console is still present, is this issue good to close out?

Summarizing our chat discussion here for any folks following along - the fix has shipped, but verification will take place once Calcite's 2.12.2 and UI Icons 3.32.0 are available later this month. 🚀

@geospatialem geospatialem added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 1, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 3, 2024

🍡 Verified on Ui Icons 3.32.0
image

@DitwanP DitwanP closed this as completed Oct 3, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. Support Issues accepted from Esri Support.
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
2 participants
@geospatialem @DitwanP