Fix diagnostic position and clearance on document close #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Recommend >= 0.2.0 of `torch-tb-profiler` (#16440) * Recommend >= 0.2.0 of torch-tb-profiler * Update CHANGELOG.md and delete news * Prep for trusted workspaces work (#16485) * Implement python.defaultInterpreterPath in workspace scope * Move DeprecatePythonPath experiment to new framework and retire old framework * Remove execution isolation script * Do not delete old user setting while migrating interpreter settings * Modify the python path deprecation prompt * Add deprecate pythonPath doc in package.json * Add default Interpreter path entry at the bottom of the interpreter list * Update VSCode engine to 1.57 * Restore Deprecate PythonPath experiment for compatibility * Remove environments security related to discovery (#17) * Remove environments security related to autoselection (#18) * Fix ESLint errors related to security undo work * Add experiment to package.json * Edit changelog to include enhancement details * Delete news entry * Update release candidate for release (#16490) * Update change log * Update version * Update TPN * Remove deprecated setting usage in DS smoke test (#16491) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> Co-authored-by: Kartik Raj <karraj@microsoft.com>
* Fix easier linting issues * Update eslint-config-prettier * Basic linting pass on start page * Update .eslintignore * Undo switch from arrow fct expression to method * Updating eslint-config-prettier wasn't a good idea * Undo a conda line reformatting for testing * Revert "Undo a conda line reformatting for testing" This reverts commit a487ce3. * fix new linting issues * Formatting issue
* Ensure JediLSP restart command is registered only once. * Add news
* Use getTreatmentVariableAsync * Fix TB tests * Update venv tests * inExperiment -> true * inDiscoveryExperiment -> true * Add logging * More logging * More more logging * Even more logging * Change logging * USe provider.constructor.name * Circular commands * replace json.interpreter(interpreter) with path * Use provider.constructor.name * add other logging before getActivationCommands * Remove both remaining JSON.stringify * inner logging * More logging in the env discovery components * Change a few things * Remove some of the *2 * Comment out some logs, double timeouts again * Add and re-add logs * Try using sync methods * Re-add isCachedFlightEnabled * Re-add isCachedFlightEnabled everywhere * Forgot the await * Clean up logging * getTreatmentVariableAsync * More cleanup * checkCache to true * Undo experiment changes after merge with main * Re-add tensorboard change * Opt into all experiments * Add comment * Undo changes + skip the entire test suite for now * Skip only on Windows * Skip on all platforms since all changes were reverted lol * Why is it so hard to skip an entire test suite
* Extract ConcatTextDocument * Improve text len cache * 💄 * find input document in iw. * hook up with jedi middleware * 💄 * postion is zero based * isClosed should include input document * Dispose NotebookConcatDocument * Properly handle onDidClose * hide diagnostics for interactive cells * unnecessary diagnostics filtering. * class per file. * update styles. * Update unit tests * Try to fix code quality * fix lint/format * remove unary operator * Fix lint * Fix lint * Run prettier * fix input document init. * 💄 * filter out non-python code. * Format * Format Co-authored-by: rebornix <penn.lv@gmail.com>
* Extract ConcatTextDocument * Improve text len cache * 💄 * find input document in iw. * hook up with jedi middleware * 💄 * postion is zero based * isClosed should include input document * Dispose NotebookConcatDocument * Properly handle onDidClose * hide diagnostics for interactive cells * unnecessary diagnostics filtering. * class per file. * update styles. * Update unit tests * Try to fix code quality * fix lint/format * remove unary operator * Fix lint * Fix lint * Run prettier * fix input document init. * 💄 * filter out non-python code. * filter cells based on selector. * move towards compose text documents other than cells. * clear diagnostics on notebook/iw close. * input document can be undefined on notebook open. * prettier Co-authored-by: Joyce Er <huer@microsoft.com>
Bumps [packaging](https://github.com/pypa/packaging) from 20.9 to 21.0. - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst) - [Commits](pypa/packaging@20.9...21.0) --- updated-dependencies: - dependency-name: packaging dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* apply system variables for poetry path * Add news entry * Fix the locator test * Fix a little comment typo * Update src/client/pythonEnvironments/common/externalDependencies.ts Co-authored-by: Kartik Raj <karraj@microsoft.com> * Consolidate changes to the base method Co-authored-by: Kartik Raj <karraj@microsoft.com>
* New comparison logic * Add experiment group * Register and call it * Add service registry tests * Add interpreter selector unit tests * Add comparison unit tests * Add intepreter selector test * News file * Adjust comments * Reuse getSortName * Add experiment to package.json * Check if environment is local before anything else * Update comment on comparison guidelines * Remove 'unknown' exception
…cienceInstaller (#16616) * Implement cases for pipenv and poetry installers * Add tests for the data science installer * Add a test for microsoft/vscode-jupyter#5034 * denote the unused parameters * Spread the news * Use a module installer type enum instead of hardcoded strings for names * Patch the tests with the enum field
* Correctly set `shellIdentificationSource`. Add an `else` to correctly set `shellIdentificationSource`. Without an `else`, Line 63 would *always* overwrite what has been set previously in Line 61. * Add news-entry for #16515
) * 16368 Only show last file/folder names on nodes in test explorer * 16368 Test expectations * 16368 Fixed linting in test * 16368 Attempted fix to lookForTestFile * 16368 Linting * 16368 Prettier (on renamed old file...?) * 16368 Fixed typo in lookForTestFile fix * Update news/2 Fixes/16368.md * Update src/test/testing/helper.ts Also match on unmodified input to forgive hybrid separators scenario in Windows tests (thanks @karthiknadig) Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
f550331 to
4d53d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-jupyter#6581