-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language server support for native interactive window #16560
Conversation
Right now when we close a notebook with diagnostics, the diagnostics are never cleared due to the flow below
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think I'd want a unit test to verify the concat stuff in the interactive concat document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no testing, do we plan to do it separately, or is it not needed? Otherwise, LGTM.
return position; | ||
} | ||
|
||
lineAt(posOrNumber: Position | number): TextLine { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why are scopes not explicitly declared for these methods? Is it because it means they are public
methods by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add a unit test this week, and there are still some other bugs with diagnostics not being cleared on document close that we will fix up in a separate PR. And yes all class members are public by default, and these methods are also supposed to be public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…o dev/joyceerhl/interactive-intellisense
No description provided.