Fix diagnostic position and clearance on document close

.eslintignore

@@ -436,7 +436,6 @@ src/client/testing/display/main.ts
 src/client/testing/display/picker.ts
 src/client/testing/configuration.ts
 
-src/client/common/serviceRegistry.ts
 src/client/common/helpers.ts
 src/client/common/net/browser.ts
 src/client/common/net/fileDownloader.ts
@@ -517,8 +516,6 @@ src/client/common/application/clipboard.ts
 src/client/common/application/workspace.ts
 src/client/common/application/debugSessionTelemetry.ts
 src/client/common/application/extensions.ts
-src/client/common/application/types.ts
-src/client/common/application/commandManager.ts
 src/client/common/application/documentManager.ts
 src/client/common/application/webPanels/webPanelProvider.ts
 src/client/common/application/webPanels/webPanel.ts
@@ -646,7 +643,6 @@ src/startPage-ui/react-common/locReactSide.ts
 src/startPage-ui/react-common/logger.ts
 src/startPage-ui/react-common/postOffice.ts
 src/startPage-ui/startPage/index.tsx
-src/startPage-ui/startPage/startPage.tsx
 src/test/startPage/mockCommandManager.ts
 src/test/startPage/mockDocument.ts
 src/test/startPage/mockDocumentManager.ts

.github/assign-reviewers.yml

@@ -14,7 +14,6 @@ team:
 # Comment yourself out when you will be unavailable for reviews for more than a
 # couple of days.
 reviewers:
-  - karthiknadig
   - karrtikr
   - kimadeline
   - paulacamargo25

.github/workflows/build.yml

@@ -388,68 +388,68 @@ jobs:
         with:
           run: node --no-force-async-hooks-checks ./out/test/smokeTest.js
 
-  insider-tests:
-    name: Insider tests
-    if: github.repository == 'microsoft/vscode-python'
-    runs-on: ${{ matrix.os }}
-    strategy:
-      fail-fast: false
-      matrix:
-        # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
-        # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
-        os: [ubuntu-latest]
-        python: [3.8] # For Jupyter.
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2.3.4
-
-      - name: Install Node
-        uses: actions/setup-node@v2.1.5
-        with:
-          node-version: ${{env.NODE_VERSION}}
-
-      - name: Use Python ${{matrix.python}}
-        uses: actions/setup-python@v2
-        with:
-          python-version: ${{matrix.python}}
-
-      - name: Install dependencies (npm ci)
-        run: npm ci --prefer-offline
-
-      - name: pip install system test requirements
-        run: |
-          python -m pip install --upgrade -r build/test-requirements.txt
-          python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade -r requirements.txt
-          python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade --pre debugpy
-        shell: bash
-
-      - name: pip install smoke test requirements
-        run: |
-          python -m pip install --upgrade -r build/smoke-test-requirements.txt
-        shell: bash
-
-      # Compile the test files.
-      - name: Prepare for insiders tests
-        run: npm run prePublish
-        shell: bash
-
-      - name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
-        run: |
-          echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
-          echo "CI_DISABLE_AUTO_SELECTION=1" >> $GITHUB_ENV
-        shell: bash
-
-      - name: Run insider tests
-        env:
-          DISPLAY: 10
-          INSTALL_JUPYTER_EXTENSION: true
-          INSTALL_PYLANCE_EXTENSION: true
-          VSC_PYTHON_CI_TEST_VSC_CHANNEL: insiders
-          TEST_FILES_SUFFIX: insiders.test
-          CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
-        uses: GabrielBB/xvfb-action@v1.5
-        with:
-          run: node --no-force-async-hooks-checks ./out/test/standardTest.js
+  #   insider-tests:
+  #     name: Insider tests
+  #     if: github.repository == 'microsoft/vscode-python'
+  #     runs-on: ${{ matrix.os }}
+  #     strategy:
+  #       fail-fast: false
+  #       matrix:
+  #         # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
+  #         # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
+  #         os: [ubuntu-latest]
+  #         python: [3.8] # For Jupyter.
+  #     steps:
+  #       - name: Checkout
+  #         uses: actions/checkout@v2.3.4
+
+  #       - name: Install Node
+  #         uses: actions/setup-node@v2.1.5
+  #         with:
+  #           node-version: ${{env.NODE_VERSION}}
+
+  #       - name: Use Python ${{matrix.python}}
+  #         uses: actions/setup-python@v2
+  #         with:
+  #           python-version: ${{matrix.python}}
+
+  #       - name: Install dependencies (npm ci)
+  #         run: npm ci --prefer-offline
+
+  #       - name: pip install system test requirements
+  #         run: |
+  #           python -m pip install --upgrade -r build/test-requirements.txt
+  #           python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade -r requirements.txt
+  #           python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade --pre debugpy
+  #         shell: bash
+
+  #       - name: pip install smoke test requirements
+  #         run: |
+  #           python -m pip install --upgrade -r build/smoke-test-requirements.txt
+  #         shell: bash
+
+  #       # Compile the test files.
+  #       - name: Prepare for insiders tests
+  #         run: npm run prePublish
+  #         shell: bash
+
+  #       - name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
+  #         run: |
+  #           echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
+  #           echo "CI_DISABLE_AUTO_SELECTION=1" >> $GITHUB_ENV
+  #         shell: bash
+
+  #       - name: Run insider tests
+  #         env:
+  #           DISPLAY: 10
+  #           INSTALL_JUPYTER_EXTENSION: true
+  #           INSTALL_PYLANCE_EXTENSION: true
+  #           VSC_PYTHON_CI_TEST_VSC_CHANNEL: insiders
+  #           TEST_FILES_SUFFIX: insiders.test
+  #           CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
+  #         uses: GabrielBB/xvfb-action@v1.5
+  #         with:
+  #           run: node --no-force-async-hooks-checks ./out/test/standardTest.js
 
   upload:
     name: Upload VSIX to Azure Blob Storage

.github/workflows/pr-check.yml

@@ -372,69 +372,69 @@ jobs:
         with:
           run: node --no-force-async-hooks-checks ./out/test/smokeTest.js
 
-  insider-tests:
-    name: Insider tests
-    # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
-    runs-on: ${{ matrix.os }}
-    strategy:
-      fail-fast: false
-      matrix:
-        # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
-        # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
-        os: [ubuntu-latest]
-        python: [3.8]
-    steps:
-      # Need the source to have the tests available.
-      - name: Checkout
-        uses: actions/checkout@v2.3.4
-
-      - name: Install Node
-        uses: actions/setup-node@v2.1.5
-        with:
-          node-version: ${{env.NODE_VERSION}}
-
-      - name: Use Python ${{matrix.python}}
-        uses: actions/setup-python@v2
-        with:
-          python-version: ${{matrix.python}}
-
-      - name: Install dependencies (npm ci)
-        run: npm ci --prefer-offline
-
-      - name: pip install system test requirements
-        run: |
-          python -m pip install --upgrade -r build/test-requirements.txt
-          python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade -r requirements.txt
-          python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade --pre debugpy
-        shell: bash
-
-      - name: pip install smoke test requirements
-        run: |
-          python -m pip install --upgrade -r build/smoke-test-requirements.txt
-        shell: bash
-
-      # Compile the test files.
-      - name: Prepare for insiders tests
-        run: npm run prePublish
-        shell: bash
-
-      - name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
-        run: |
-          echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
-          echo "CI_DISABLE_AUTO_SELECTION=1" >> $GITHUB_ENV
-        shell: bash
-
-      - name: Run insider tests
-        env:
-          DISPLAY: 10
-          INSTALL_JUPYTER_EXTENSION: true
-          INSTALL_PYLANCE_EXTENSION: true
-          VSC_PYTHON_CI_TEST_VSC_CHANNEL: insiders
-          TEST_FILES_SUFFIX: insiders.test
-          CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
-        uses: GabrielBB/xvfb-action@v1.5
-        with:
-          run: node --no-force-async-hooks-checks ./out/test/standardTest.js
+  #   insider-tests:
+  #     name: Insider tests
+  #     # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
+  #     runs-on: ${{ matrix.os }}
+  #     strategy:
+  #       fail-fast: false
+  #       matrix:
+  #         # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
+  #         # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
+  #         os: [ubuntu-latest]
+  #         python: [3.8]
+  #     steps:
+  #       # Need the source to have the tests available.
+  #       - name: Checkout
+  #         uses: actions/checkout@v2.3.4
+
+  #       - name: Install Node
+  #         uses: actions/setup-node@v2.1.5
+  #         with:
+  #           node-version: ${{env.NODE_VERSION}}
+
+  #       - name: Use Python ${{matrix.python}}
+  #         uses: actions/setup-python@v2
+  #         with:
+  #           python-version: ${{matrix.python}}
+
+  #       - name: Install dependencies (npm ci)
+  #         run: npm ci --prefer-offline
+
+  #       - name: pip install system test requirements
+  #         run: |
+  #           python -m pip install --upgrade -r build/test-requirements.txt
+  #           python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade -r requirements.txt
+  #           python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade --pre debugpy
+  #         shell: bash
+
+  #       - name: pip install smoke test requirements
+  #         run: |
+  #           python -m pip install --upgrade -r build/smoke-test-requirements.txt
+  #         shell: bash
+
+  #       # Compile the test files.
+  #       - name: Prepare for insiders tests
+  #         run: npm run prePublish
+  #         shell: bash
+
+  #       - name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
+  #         run: |
+  #           echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
+  #           echo "CI_DISABLE_AUTO_SELECTION=1" >> $GITHUB_ENV
+  #         shell: bash
+
+  #       - name: Run insider tests
+  #         env:
+  #           DISPLAY: 10
+  #           INSTALL_JUPYTER_EXTENSION: true
+  #           INSTALL_PYLANCE_EXTENSION: true
+  #           VSC_PYTHON_CI_TEST_VSC_CHANNEL: insiders
+  #           TEST_FILES_SUFFIX: insiders.test
+  #           CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
+  #         uses: GabrielBB/xvfb-action@v1.5
+  #         with:
+  #           run: node --no-force-async-hooks-checks ./out/test/standardTest.js
 
   ### Coverage run
   coverage:

CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 2021.6.0-rc (9 June 2021)
+## 2021.6.0 (16 June 2021)
 
 ### Enhancements
 
@@ -20,7 +20,7 @@
    ([#16485](https://github.com/Microsoft/vscode-python/issues/16485))
 1. Show `python.pythonPath` deprecation prompt when in `pythonDeprecatePythonPath` experiment.
    ([#16485](https://github.com/Microsoft/vscode-python/issues/16485))
-1. Do not show safety prompt before autoselecting a workspace interpreter.
+1. Do not show safety prompt before auto-selecting a workspace interpreter.
    ([#16485](https://github.com/Microsoft/vscode-python/issues/16485))
 1. Assume workspace interpreters are safe to execute for discovery.
    ([#16485](https://github.com/Microsoft/vscode-python/issues/16485))