Dev v2 #1
Merged
Dev v2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=214784773
If a source is removed from the playlist, the player may still call createPeriod for a period of the removed source as long as the new timeline hasn't been handled by the player. These events are stale and can be ignored by using a dummy media source. The stale media period will be released when the player handles the updated timeline. Issue:#4871 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=214787090
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=214784773
If a source is removed from the playlist, the player may still call createPeriod for a period of the removed source as long as the new timeline hasn't been handled by the player. These events are stale and can be ignored by using a dummy media source. The stale media period will be released when the player handles the updated timeline. Issue:#4871 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=214787090
More specifically, if the parts of the Format that are used for decoder configuration are unchanged. Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=214791234
This allows selectAudioTrack() to be overridden.
This makes the annotations appear in the generated JavaDoc. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=214952419
Extend Sony workaround up to and including Oreo. Due to a platform issue the Display API couldn't report 1080p UI and 4k SurfaceView support until Oreo. Since Oreo it is still common for devices to misreport their display sizes via Display, so this change switches to using system properties up to and including Pie. On Pie treble may prevent writing sys.display-size so check for vendor.display-size instead. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=214987203
Switch to the recommended way of checking whether the app is running on a TV device. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215177587
These two methods are meant to indicate to the track selection that it's started or stopped being used. This is helpful to schedule background tasks related to track selection (e.g. register network change listeners etc.). This intention is not clearly stated in the method docs. Also, all track selections of all prebuffered periods stay enabled in parallel at the moment. As the whole purpose of these methods is to know whether dynamic updates via updateSelectedTrack may happen, it's better to only enable track selections of the current loading media period. That's similar to how we always forward the loading track selections to the LoadControl. This change: 1. Improves the JavaDoc of TrackSelection. 2. Disables track selections if loading moves to another period. 3. Reenables track selection if loading moves back to a previous period. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215199987
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215205796
…o offset. If we prepare a deferred media period before the actual timeline is available, we either prepare with position zero (= the default) or with a non-zero initial seek position. So far, the zero (default) position got replaced by the actual default position (including any potential non-zero window offset) when the timeline became known. However, a non-zero initial seek position was not corrected by the non-zero window offset. This is fixed by this change. Related to that, we always assumed that the deferred media period will the first period in the actual timeline. This is not true if we prepare with an offset (either because of an initial seek position or because of a default window position). So, we also determine the actual first period when the timeline becomes known. Issue:#4873 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215213030
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215213255
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215214894
Make DefaultTrackSelector.AudioTrackScore protected
Call rating with extras
…nts, setting Cue's textAlignment to def value - null
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215261807
…version. For example, using ExoPlayer.STATE_IDLE falls back to the Player.STATE_IDLE automatically and thus there is no need to keep the deprecated members. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215363841
A lot of methods just forward to other methods and there is no conceivable way a player should implement it another way. Moving these methods to a base player class allows to remove duplicated code across our player implementations. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215374192
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215389291
This removes the experimental bandwidth meter and uses it as the new default. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215404065
SubtitleView forwards the cue box position to SubtitlePainter. This should be the position relative to the canvas of the SubtitleView. Currently, however, we forward the position relative to the parent of SubtitleView. That causes problems if SubtitleView has a non-zero offset position to its parent. Issue:#4788 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215535281
When SubtitlePainter positions the cues centred in the given box, it must add the left offset of the box to get the correct position. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215535289
Issue: #5063 PiperOrigin-RevId: 222975020
PiperOrigin-RevId: 222978255
…lable Issue: #5119 PiperOrigin-RevId: 222978448
Issue: #5149 PiperOrigin-RevId: 223121651
PiperOrigin-RevId: 223141203
Issue: #5162 PiperOrigin-RevId: 223193019
PiperOrigin-RevId: 223206504
Issue: #5154 PiperOrigin-RevId: 223314749
PiperOrigin-RevId: 223324279
PiperOrigin-RevId: 223476569
It doesn't do anything useful in this case. PiperOrigin-RevId: 223516909
PiperOrigin-RevId: 223518390
PiperOrigin-RevId: 223520119
The list may be empty if no cues are available. PiperOrigin-RevId: 223527105
PiperOrigin-RevId: 223535353
It doesn't make sense for multi-period manifest PiperOrigin-RevId: 223537958
PiperOrigin-RevId: 223580953
…remove all media periods after PiperOrigin-RevId: 223603915
…d track bandwidth This option to block bandwidth already exists on the AdaptiveTrackSelection itself but it's not currently possible to forward the total fixed track bandwidth automatically. PiperOrigin-RevId: 223785139
PiperOrigin-RevId: 223787832
PiperOrigin-RevId: 223796377
PiperOrigin-RevId: 223797364
Issue #5013 PiperOrigin-RevId: 223838303
|
Pull from google:dev-v2 |
dwhea
pushed a commit
that referenced
this pull request
Jun 7, 2021
Colocate lines that refer to the same module, to reduce probability of accidentally removing one line and not the other (which has happened more than once :)). PiperOrigin-RevId: 374847082
ybai001
pushed a commit
that referenced
this pull request
Jun 8, 2022
``` [expression.parameter.name.shadows.field] The postcondition EnsuresNonNull on the declaration of method 'setContentTimeline' contains ambiguous identifier 'contentTimeline'. Use "this.contentTimeline" for the field, or "#1" for the formal parameter. private void setContentTimeline(Timeline contentTimeline) { ^ ``` PiperOrigin-RevId: 448285571
ybai001
pushed a commit
that referenced
this pull request
Aug 5, 2022
``` [expression.parameter.name.shadows.field] The postcondition EnsuresNonNull on the declaration of method 'setContentTimeline' contains ambiguous identifier 'contentTimeline'. Use "this.contentTimeline" for the field, or "#1" for the formal parameter. private void setContentTimeline(Timeline contentTimeline) { ^ ``` PiperOrigin-RevId: 448285571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.