Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultTrackSelector.AudioTrackScore protected #4886

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

talklittle
Copy link
Contributor

This allows selectAudioTrack() to be overridden.

This allows selectAudioTrack() to be overridden.
@AquilesCanta
Copy link
Contributor

I am a bit inclined to think it should remain private, and subclasses should fork if necessary.

Otherwise, when changing the implementation of selectAudioTrack, we might break the contract of this class. So what should have been an implementation change becomes an API change.

If we don't care about eventually breaking the API, seems reasonable.

@talklittle
Copy link
Contributor Author

selectAudioTrack is already protected, and the API already had a breaking change (adding the AudioTrackScore to the return type) going from 2.8.4 to 2.9.0, so I don't think that's a concern. If it's not meant to be overridden, then selectAudioTrack should have been marked protected final or private originally.

@AquilesCanta
Copy link
Contributor

Oh right. We now return the score.

@ojw28 ojw28 merged commit b4ba913 into google:dev-v2 Oct 1, 2018
@google google locked and limited conversation to collaborators Jan 31, 2019
@talklittle talklittle deleted the protected-audiotrackscore branch August 22, 2021 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants