Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev v2 #1

Merged
merged 2,588 commits into from
Dec 5, 2018
Merged
Changes from 1 commit
Commits
Show all changes
2588 commits
Select commit Hold shift + click to select a range
a394ab7
Update release notes for 2.9.0
andrewlewis Sep 27, 2018
827ea63
Fix issue with stale createPeriod events in ConcatenatingMediaSource.
tonihei Sep 27, 2018
66c9d41
Update release notes for 2.9.0
andrewlewis Sep 27, 2018
150e54b
Fix issue with stale createPeriod events in ConcatenatingMediaSource.
tonihei Sep 27, 2018
1f9a003
Merge branch 'release-v2' into dev-v2-r2.9.0
ojw28 Sep 27, 2018
afba638
Merge pull request #4881 from google/dev-v2-r2.9.0
ojw28 Sep 27, 2018
1dd0533
Merge branch 'release-v2' into dev-v2
ojw28 Sep 27, 2018
028f3e6
Don't recreate the audio decoder if Format is unchanged
ojw28 Sep 27, 2018
47ce263
Call rating with extras
hacker1024 Sep 27, 2018
9b111fb
Make DefaultTrackSelector.AudioTrackScore protected
talklittle Sep 28, 2018
5c8daba
Add @Documented to @IntDef and @StringDef annotations.
tonihei Sep 28, 2018
5d5b641
Extend physical display size workaround for ATVs
andrewlewis Sep 28, 2018
f59f557
Use recommended way of checking for TV
andrewlewis Oct 1, 2018
d97d289
Clarify and improve TrackSelection .enable() and .disable() calls.
tonihei Oct 1, 2018
90ca371
Improve MediaPeriodHolder documentation and member access.
tonihei Oct 1, 2018
46731cd
Fix prepare position of DeferredMediaPeriods for windows with non-zer…
tonihei Oct 1, 2018
7940fdf
Fix DownloadManager.TaskState javadoc
erdemguven Oct 1, 2018
6cc049f
Increase supported libflac version to 1.3.2
erdemguven Oct 1, 2018
b4ba913
Merge pull request #4886 from talklittle/protected-audiotrackscore
ojw28 Oct 1, 2018
a7f8226
Merge pull request #4884 from hacker1024/patch-1
ojw28 Oct 1, 2018
fc5eb12
#4306 - breaking after the first alignment tag is found
szaboa Oct 1, 2018
75a7385
#4306 - extends test case with line and position anchor verifications
szaboa Oct 1, 2018
56c7e1f
#4306 - grouping line/lineAnchor and position/positionAnchor assignme…
szaboa Oct 2, 2018
687756e
Update moe equivalence
ojw28 Oct 1, 2018
8b2d998
Remove deprecated ExoPlayer members with same name as non-deprecated …
tonihei Oct 2, 2018
a8b851c
Add BasePlayer to avoid code duplication for common convenience methods.
tonihei Oct 2, 2018
34c2866
Extract PlayerManager interface in the Cast demo app
AquilesCanta Oct 2, 2018
4386d5d
Replace DefaultBandwidthMeter with CountryAndNetworkTypeBandwidthMeter.
tonihei Oct 2, 2018
43c0156
Fix positioning of subtitles.
tonihei Oct 3, 2018
f0e0a7c
Fix left position for subtitles.
tonihei Oct 3, 2018
9f8c22d
Make it possible to use CacheKeyFactory with CacheDataSourceFactory a…
erdemguven Oct 3, 2018
645f08a
Prevent binding to DownloadService
erdemguven Oct 3, 2018
e91065c
Remove ProjectionRenderer.EyeType
erdemguven Oct 3, 2018
16fe67b
Merge pull request #4582 from szaboa/feature/4306_srt_position_tags
ojw28 Oct 3, 2018
7849a5e
Subrip cleanup
ojw28 Oct 3, 2018
35cc479
Create unique id for hls audio and text tracks
Oct 4, 2018
57d90f3
add test for setForceHighestSupportedBitrate
Oct 5, 2018
e42786d
added parsing for program information
jlieblich2 Oct 10, 2018
8a671c1
add check to ensure single track selection
Oct 11, 2018
a5b7276
Correct javadoc for forced bitrate tests
Oct 11, 2018
211a2df
Ensure formats have unique ids
Oct 11, 2018
30c7954
add bitrate that is unsupported by renderer
Oct 11, 2018
ce0b5e4
removed custom element parsing
jlieblich2 Oct 11, 2018
6cbac15
added attribute parsin
jlieblich2 Oct 11, 2018
ced302f
added javadoc for ProgramInformation
jlieblich2 Oct 12, 2018
9ca6544
Simplify some buffered position related code.
tonihei Oct 4, 2018
711f9f8
Add test action to wait for an isLoading change.
tonihei Oct 4, 2018
d4b87cd
Fix updates of loading period and buffered positions in PlaybackInfo.
tonihei Oct 4, 2018
cc7684d
Introduce Renderer.reset
ojw28 Oct 4, 2018
76a1569
Update release notes to better describe Java 8 change.
tonihei Oct 4, 2018
c5f9ad9
Minor fixes for period clipping
ojw28 Oct 4, 2018
8dedbd5
Fix release notes Markdown syntax
andrewlewis Oct 5, 2018
0a7745b
Fix some random Android Studio warnings.
tonihei Oct 5, 2018
048c8bd
Snapshots are going to become the default soon and these tests are fa…
vsethia Oct 11, 2018
81a9293
Project start position for preroll ad to content transitions
andrewlewis Oct 11, 2018
42c3ff3
Handle rotation signaled in MKV track name from HTC devices
andrewlewis Oct 11, 2018
842f622
Allow codec flushing without re-initialization
ojw28 Oct 12, 2018
ba6a118
Retain decoder instance after the renderer is disabled
ojw28 Oct 12, 2018
d511370
Fix DashManifestParser to properly skip unknown tags
ojw28 Oct 15, 2018
6fb8f66
Remove assertion causing failure on some Samsung devices
ojw28 Oct 15, 2018
a7ace58
Merge branch 'dev-v2' into program_information
jlieblich2 Oct 15, 2018
0af9ccc
added handling of unexpected tags
jlieblich2 Oct 15, 2018
6e7b415
No-op cleanup of DefaultDrmSessionManager
ojw28 Oct 15, 2018
dbf5b07
Network type cleanup
ojw28 Oct 15, 2018
bfd6799
Add ExoPlayer.setForegroundMode
ojw28 Oct 15, 2018
ee02c67
Support seeking based on MLLT metadata
andrewlewis Oct 16, 2018
cc91449
Rename libvpxJNI.so to libvpxV2JNI.so
Oct 16, 2018
423a954
Automated g4 rollback of changelist 217189082.
falhassen Oct 16, 2018
86fdcb0
Fix documentation confusion in MediaChunkIterator subclasses
erdemguven Oct 17, 2018
05a98a7
Code shrinking doesn't like Class.super.defaultMethodName
ojw28 Oct 18, 2018
1c6abc8
Set output on surface in all states
ojw28 Oct 18, 2018
50dd089
Update the cast framework gradle dependency in the Cast extension
AquilesCanta Oct 18, 2018
80e9c84
Remove RemotePlayer
AquilesCanta Oct 18, 2018
3805717
Decouple dummySurface lifespan from codec lifespans
ojw28 Oct 18, 2018
1ef3efa
Automated g4 rollback of changelist 217356705.
ojw28 Oct 18, 2018
861b816
Allow setting the ad media bitrate in ImaAdsLoader
ogaclejapan Oct 21, 2018
cfcbd21
Allow setting the ad UI elements to be rendered in ImaAdsLoader
ogaclejapan Oct 21, 2018
090a992
Fix setMediaBitrateKbps naming from consistency point of view
ogaclejapan Oct 23, 2018
23666e3
Fix adUiElements variables even more robust
ogaclejapan Oct 23, 2018
9d114b1
fix checkIdleRequirement
YukiMatsumura Oct 23, 2018
8c5703e
Provide http status message to InvalidResponseCodeException
pakerfeldt Oct 23, 2018
70ccbc6
Fix review comments
tonihei Oct 23, 2018
8f3c3e2
Add GlUtil createBuffer overload which doesn't copy values
erdemguven Oct 19, 2018
bf57d44
Update VR video player sample app
ojw28 Oct 19, 2018
4c6507e
Remove deprecated MediaSource.prepareSource.
tonihei Oct 19, 2018
ca4b5d0
Make context non-optional for DefaultBandwidthMeter
ojw28 Oct 19, 2018
6977fdb
Properly reset period id and start position in ExoPlayerImpl.
tonihei Oct 19, 2018
0834d12
Make VpxOutputBuffer public
Oct 19, 2018
42c9b24
Make context non-optional in AudioFocusManager
ojw28 Oct 19, 2018
bb5a9ef
Remove extra blank line
andrewlewis Oct 19, 2018
f3b4575
Temporarily disable codec reuse
ojw28 Oct 19, 2018
62759e8
Cleanup VR video player sample app
ojw28 Oct 20, 2018
4170c79
Add ACCESS_NETWORK_STATE permission for MH tests
andrewlewis Oct 21, 2018
ea49d39
Add VR string and icon
erdemguven Oct 22, 2018
5ce2f17
Check if source has been prepared before releasing it.
tonihei Oct 22, 2018
4343dc6
Remove the Uri suffix from MediaItem.DrmScheme.licenseServerUri
AquilesCanta Oct 22, 2018
e1ba9b0
vp9_extension: Enable fast loop filtering
vigneshvg Oct 22, 2018
2d63be0
Swap google() and jcenter() in docs and gradle config.
tonihei Oct 23, 2018
2fc1227
Give EventDispatcher more predictable behavior
ojw28 Oct 23, 2018
66c5086
Cleanup codec init, flush and release
ojw28 Oct 23, 2018
d56b7ad
Clean up codec reinitialization
ojw28 Oct 23, 2018
66a6921
Remove non-addEventListener ways of adding an event listener
ojw28 Oct 23, 2018
706ce49
Fix handling of MP3s with appended data
andrewlewis Oct 23, 2018
1b6801c
Simplify setting of codec operating rate
ojw28 Oct 24, 2018
4fe14c7
Minor cleanup to BandwidthMeter/DefaultBandwidthMeter
ojw28 Oct 24, 2018
ede62e9
Fix track selection when forceLowestBitrate is enabled:
ojw28 Oct 25, 2018
9ea678c
Add ExoCastMessage
AquilesCanta Oct 26, 2018
ed32e2a
Add TrackSelectionUtil.getAverageBitrate method
erdemguven Oct 26, 2018
194d0f3
Add a bit of structure DefaultTrackSelector, for sanity
ojw28 Oct 29, 2018
5de17b9
Add support for playing spherical videos on Daydream
erdemguven Oct 29, 2018
4824f35
Decouple input format and codec format
ojw28 Oct 29, 2018
0382384
Re-enable codec re-use
ojw28 Oct 29, 2018
069e3cb
Clean up DefaultTrackSelectorTest
ojw28 Oct 29, 2018
7eeeb40
Add options for controlling audio track selection
ojw28 Oct 29, 2018
053a7bc
Simplify DefaultDrmSession event handling
ojw28 Oct 29, 2018
4b9530c
Let apps specify whether to focus skip button on ATV
andrewlewis Oct 30, 2018
1094da2
Fix player state transitions for postroll ads
andrewlewis Oct 31, 2018
53e06e6
Clean up ExoHostedTest.
tonihei Oct 31, 2018
7d99794
Allow MP4s with truncated stco to be played
andrewlewis Oct 31, 2018
5f6c907
Reset DefaultBandwidthMeter on network type change
ojw28 Oct 31, 2018
58f50ca
Clarify Java 8 gradle requirement in developer guide.
tonihei Oct 31, 2018
db832d6
Add equals and hashCode to MediaItem
AquilesCanta Oct 31, 2018
140d5fc
Fix naming in MediaItemTest
AquilesCanta Oct 31, 2018
9d947a5
Add MediaChunkListIterator
erdemguven Oct 31, 2018
0501b67
Merge pull request #4911 from Comcast/feature/hls-audio-text-id-uniqu…
ojw28 Oct 31, 2018
0257329
Merge pull request #4996 from YukiMatsumura/fix-idle-requirements
ojw28 Oct 31, 2018
097c045
Resolve conflicts
ojw28 Oct 31, 2018
988225c
Merge branch 'Comcast-task/add_force_highest_bitrate_test' into dev-v2
ojw28 Oct 31, 2018
f1d31bd
Fix test
ojw28 Oct 31, 2018
3b7d0b7
Merge pull request #5004 from pakerfeldt/status-message-invalidrespon…
ojw28 Oct 31, 2018
0b5ef52
Merge branch 'task/add_force_highest_bitrate_test' of https://github.…
ojw28 Oct 31, 2018
3868141
Merge branch 'customize-ads-rendering-settings-more' of https://githu…
ojw28 Oct 31, 2018
24e4a61
Merge branch 'ogaclejapan-customize-ads-rendering-settings-more' into…
ojw28 Oct 31, 2018
16326ba
Merge pull request #4930 from Comcast/program_information
ojw28 Oct 31, 2018
2dfe7a7
Misc fixes / stylistic consistency changes for merged pull requests
ojw28 Oct 31, 2018
a442c72
Fix nullability
ojw28 Oct 31, 2018
609f10b
Update moe equivalence
ojw28 Oct 31, 2018
f76b80c
Automated g4 rollback of changelist 219130576.
Nov 1, 2018
36fef95
Fix extended service number calculation
andrewlewis Nov 1, 2018
e1c6229
Bump version to 2.9.1
ojw28 Nov 1, 2018
7668858
Add TrackSelectionUtil.getAverageBitrates method
erdemguven Nov 1, 2018
3b1d0e2
Double the buffer duration for AC3
andrewlewis Nov 2, 2018
b055531
Move all messaging constants to ExoCastConstants
AquilesCanta Nov 2, 2018
32927bb
Update the DefaultExtractorInput's peek buffer length on each write
AquilesCanta Nov 2, 2018
3479765
Add support for .cmf* extension in DefaultHlsExtractorFactory
AquilesCanta Nov 2, 2018
251c420
Experimental parameter for setting a render time limit in MediaCodecR…
ojw28 Nov 2, 2018
c5db69d
Fix further issues with decoder re-use
ojw28 Nov 2, 2018
37f4540
Move BaseGvrPlayerActivity to com.google.android.exoplayer2.ext.gvr
erdemguven Nov 2, 2018
894bac6
Tweak dev guide / readme
ojw28 Nov 5, 2018
0afd9c1
Add TrackSelectionUtil getBitratesUsingPastInfo
erdemguven Nov 5, 2018
8844694
Automated g4 rollback of changelist 219585084.
ojw28 Nov 5, 2018
a8d1f04
Document error case for generateAudioSessionIdV21
andrewlewis Nov 5, 2018
032883e
Work around non-empty EoS buffers with timestamp 0
andrewlewis Nov 6, 2018
bc5e120
Remove executable bit from some resources
andrewlewis Nov 6, 2018
abb7d8a
Include UI module tests in open source push
andrewlewis Nov 6, 2018
0c4d0ee
Fix for #5055 - Cannot disable audio focus after enabled.
nic0lette Nov 6, 2018
d7e23f8
Fix package visibility comments
erdemguven Nov 6, 2018
7a114cb
Uncomment VisibleForTesting annotations
erdemguven Nov 7, 2018
5a18a98
Add TrackSelectionUtil getBitratesUsingPastAndFutureInfo
erdemguven Nov 7, 2018
0dfd478
Add missing update on repeat toggle mode change
ojw28 Nov 7, 2018
2d606f2
Minor cleanup to mediasession extension
ojw28 Nov 7, 2018
15dda17
Make TimelineQueueNavigator shuffle aware
ojw28 Nov 7, 2018
e82d29f
Make BasePlayer.get[Next/Previous]WindowIndex more useful
ojw28 Nov 7, 2018
8d833c3
Fix BasePlayer.next()
ojw28 Nov 7, 2018
f895be6
AudioFocusManager - Treat idle state consistently
ojw28 Nov 7, 2018
158bc1e
Add TrackBitrateEstimator and WindowedTrackBitrateEstimator
erdemguven Nov 7, 2018
b44f837
Update release notes for 2.9.1
ojw28 Nov 8, 2018
91d9fbd
pass the notification listener to the constructor
marcbaechinger Nov 8, 2018
bce1fab
Include channel count in capabilities check
andrewlewis Nov 8, 2018
4754aa5
Use estimated bitrates in AdaptiveTrackSelection
erdemguven Nov 8, 2018
8ec757a
Some MediaSessionConnector simplifications
ojw28 Nov 9, 2018
063f570
Simplify MediaSessionConnector
ojw28 Nov 9, 2018
7508219
Simplify PlayerControlView fast forward and rewind implementation
ojw28 Nov 12, 2018
eb6859e
Align navigation implementation across UI components
ojw28 Nov 12, 2018
afebaed
Make support-media-compat an API dependency
ojw28 Nov 12, 2018
51461d7
Add constructor to DefaultShuffleOrder to support sideloaded shuffle …
AquilesCanta Nov 12, 2018
9ca019b
PlaybackNotificationManager should show play button in ENDED state
ojw28 Nov 12, 2018
f5af6e8
Document need to call MediaSessionCompat.setActive
ojw28 Nov 12, 2018
c20b157
Wire up experiment to use AdaptiveTrackSelection based selections
ojw28 Nov 12, 2018
866b088
Noop cleanup of binary seeking / duration reading.
ojw28 Nov 14, 2018
76eb06d
Add Timeline to nullness check
AquilesCanta Nov 14, 2018
5e6174f
DASH: Fix detection of end of live events
ojw28 Nov 14, 2018
b771091
Workaround for TS seeking
ojw28 Nov 14, 2018
67b6621
Add binarySearchCeil method for integers
AquilesCanta Nov 15, 2018
7cf62a0
Ensure DefaultLoadControl.Builder is single-use.
tonihei Nov 15, 2018
9dd814f
Improve DefaultLoadControl.shouldContinueLoading for the minBuffer=ma…
tonihei Nov 15, 2018
c096e15
Interpret single-item audio stream edit lists as audio padding specif…
Nov 16, 2018
f48ad85
Add experiment to use WindowedTrackBitrateEstimator
erdemguven Nov 19, 2018
a3c0469
Update IMA SDK and Play Services Ads versions
andrewlewis Nov 19, 2018
edff52b
Add buffer size based adaptive track selection.
tonihei Nov 20, 2018
771db2c
Move playWhenReady update out of PlaybackInfoUpdate.
tonihei Nov 20, 2018
b7ab570
Use serialized listener notification for all listener notifications.
tonihei Nov 20, 2018
55cc0df
Create actual copy of listener list instead of just copying the refer…
tonihei Nov 20, 2018
527f2cf
Add TrackSelection.Factory createTrackSelections
erdemguven Nov 20, 2018
6ebb612
Offline refactor step 1a - Make DownloadAction concrete
ojw28 Nov 20, 2018
10eaa7d
Replace BandwidthMeter with BandwidthProvider in AdaptiveTrackSelection
erdemguven Nov 20, 2018
1699fbf
Add experimental option to subtract non-allocatable bandwidth.
tonihei Nov 21, 2018
42cb2c0
Add test that DefaultDataSource is able to build an RtmpDataSource
ojw28 Nov 21, 2018
265462b
Support Opus and Flac in MP4/DASH
ojw28 Nov 21, 2018
5f12b06
Support removal of ranges from ShuffleOrders
AquilesCanta Nov 21, 2018
dd47bff
Fix HLS ID3 sniffing
ojw28 Nov 21, 2018
fd2f8ea
Make ABR playback tests more resilient to HostActivity failures.
tonihei Nov 21, 2018
dd2cba0
Offline refactor step 1b - Consolidate tests
ojw28 Nov 22, 2018
56e4860
Remove stray proguard files
ojw28 Nov 23, 2018
f8a3c13
Use overflow-save add operation for blacklisting duration.
tonihei Nov 22, 2018
1a9705e
Fix show_buffering attribute values.
tonihei Nov 23, 2018
fe41f17
Move listener invocation classes to BasePlayer
AquilesCanta Nov 23, 2018
d3095cc
Merge #5126: fix(playlist): always call onCompletion when moving medi…
BrainCrumbz Nov 23, 2018
ea8696d
Ensure changes are reflected into attrs
ojw28 Nov 23, 2018
1216068
Add Lint.IfChange/ThenChange for repeat modes
ojw28 Nov 23, 2018
0c385a8
Clarify contribution branch
ojw28 Nov 23, 2018
e2e1c45
Merge #5140: Cea608 - Check parity and valid bits
ojw28 Nov 23, 2018
799bf16
Pull reading of data bytes back above if(...){continue} clauses
ojw28 Nov 23, 2018
166acad
Noop fix to WebvttDecoder
ojw28 Nov 26, 2018
0310144
Update content url for IMA demo app
ojw28 Nov 26, 2018
17eadcc
Fix Cea608 caption valid
ojw28 Nov 26, 2018
5284ad2
Merge pull request #5144 from google:dev-v2-vttfix
ojw28 Nov 26, 2018
40c65db
Move deserialization code to a more natural location
ojw28 Nov 26, 2018
d6b6600
Fix unnecessary media playlist requests when playing live streams
ojw28 Nov 26, 2018
3e150b5
Assume text tracks in protected SmoothStreaming are not protected
ojw28 Nov 26, 2018
30e753e
Provide Cronet request and response data for subclasses.
tonihei Nov 26, 2018
a31a3f3
Simplify DownloadActionTest legacy tests using assets
ojw28 Nov 26, 2018
f4d9ded
Remove spurious VisibleForTesting annotation
ojw28 Nov 26, 2018
e317305
Remove custom data from remove actions
ojw28 Nov 26, 2018
aacb212
Remove duplicate CacheAsserts class
ojw28 Nov 27, 2018
6819192
Clean up CacheDataSourceTest
ojw28 Nov 27, 2018
1ce3336
Strip private ID3 data from HLS sample formats
ojw28 Nov 27, 2018
19a6f90
Reformat cast DemoUtil
andrewlewis Nov 27, 2018
05a79a4
Fall back to TYPE_ROTATION_VECTOR if TYPE_GAME_ROTATION_VECTOR unavai…
ojw28 Nov 27, 2018
510749f
Handle metadata failing to decode in MetadataRenderer
andrewlewis Nov 28, 2018
f45943b
Bump for 2.9.2
ojw28 Nov 28, 2018
699fee9
Replace remaining stbl assertions with warnings
andrewlewis Nov 28, 2018
59cf8c1
Add missing dot at the end of RELEASENOTES item
AquilesCanta Nov 28, 2018
1093aaf
Specify a version for the FFmpeg dependency
andrewlewis Nov 29, 2018
282cf30
Fix clearkey DRM UUID passed to MediaCrypto
andrewlewis Nov 29, 2018
ea483f8
Fix some potential Uri nullness violations.
tonihei Nov 30, 2018
beae7c9
Don't resolve UtcTiming element for static manifests
ojw28 Nov 30, 2018
88af944
Move CachedContentIndex and SimpleCacheSpan tests to robolectric
ojw28 Nov 30, 2018
8ee1af2
Update release notes for 2.9.2
ojw28 Nov 30, 2018
8ffef3d
Add clarification to TextOutput doc.
tonihei Nov 30, 2018
a1b8e17
Remove Representation.contentId. It doesn't really make sense.
ojw28 Nov 30, 2018
d650f8e
Remove ability to inject content-id via DashManifestParser
ojw28 Nov 30, 2018
d98ab35
Add several devices to setOutputSurface workaround:
ojw28 Nov 30, 2018
ffbb0da
Prevent Cea608Decoder from generating Subtitles with null Cues list.
ojw28 Nov 30, 2018
24f2cbb
updateQueuedPeriods(): If known duration changed for a media period, …
ojw28 Dec 1, 2018
9f1e32f
Add experimental flag to AdaptiveTrackSelection.Factory to block fixe…
tonihei Dec 3, 2018
500b1fa
Add Downloader.getTotalBytes() method
erdemguven Dec 3, 2018
f196630
Remove contentId from Representation creators/constructor
ojw28 Dec 3, 2018
87a74ee
Simplify DownloadManager.Task to use external state
ojw28 Dec 3, 2018
8de149e
Use custom cache key factory for removal as well as downloading
ojw28 Dec 3, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update moe equivalence
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=215261807
  • Loading branch information
ojw28 committed Oct 3, 2018
commit 687756ed31090e91cc57d26dd13e2593c4d4e343
Original file line number Diff line number Diff line change
@@ -259,7 +259,7 @@ public interface RatingCallback extends CommandReceiver {

/** See {@link MediaSessionCompat.Callback#onSetRating(RatingCompat)}. */
void onSetRating(Player player, RatingCompat rating);

/** See {@link MediaSessionCompat.Callback#onSetRating(RatingCompat, Bundle)}. */
void onSetRating(Player player, RatingCompat rating, Bundle extras);
}
@@ -1005,7 +1005,7 @@ public void onSetRating(RatingCompat rating) {
ratingCallback.onSetRating(player, rating);
}
}

@Override
public void onSetRating(RatingCompat rating, Bundle extras) {
if (canDispatchToRatingCallback(PlaybackStateCompat.ACTION_SET_RATING)) {
Loading