Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JanEbbing
Currently an exception is thrown when we try to translate an empty string.
This seems to be an unnecessary check because if I remove the check manually in my vendors, the API works fine.
When receiving multiple users inputs and if we want to translate for instance
This seems unnecessary to ask us to
''
value[0 => 'foo', 1 => 'bar', 3 => 'baz']
(while the API call lose the initial keys)While an API call with
['foo', 'bar', '', 'baz']
seems to works fine if the input validation is removed.