fix: Allow translating empty strings

Co-authored-by: JanEbbing <Jan.Ebbing@deepl.com>
DeepLcom · Jun 26, 2023 · 949a528 · 949a528
1 parent f7c61d9
commit 949a528
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/Translator.php b/src/Translator.php
@@ -590,16 +590,16 @@ private function validateAndAppendTexts(array &$params, $texts)
     {
         if (is_array($texts)) {
             foreach ($texts as $text) {
-                if (!is_string($text) || strlen($text) === 0) {
+                if (!is_string($text)) {
                     throw new DeepLException(
-                        'texts parameter must be a non-empty string or array of non-empty strings',
+                        'texts parameter must be a string or array of strings',
                     );
                 }
             }
         } else {
-            if (!is_string($texts) || strlen($texts) === 0) {
+            if (!is_string($texts)) {
                 throw new DeepLException(
-                    'texts parameter must be a non-empty string or array of non-empty strings',
+                    'texts parameter must be a string or array of strings',
                 );
             }
         }

diff --git a/tests/TranslateTextTest.php b/tests/TranslateTextTest.php
@@ -89,7 +89,7 @@ public function testInvalidTargetLanguage(?ClientInterface $httpClient)
 
     public function invalidTextParameters(): array
     {
-        return [[''], [['']]];
+        return [[42], [[42]]];
     }
 
     /**
@@ -120,6 +120,17 @@ public function testTranslateWithRetries(?ClientInterface $httpClient)
         $this->assertGreaterThan(1.0, $timeAfter - $timeBefore);
     }
 
+    /**
+     * @dataProvider provideHttpClient
+     */
+    public function testEmptyText(?ClientInterface $httpClient)
+    {
+        $this->needsRealServer();
+        $translator = $this->makeTranslator([TranslatorOptions::HTTP_CLIENT => $httpClient]);
+
+        $this->assertEquals('', $translator->translateText('', null, 'de')->text);
+    }
+
     /**
      * @dataProvider provideHttpClient
      */