Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to translate empty strings #24

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Allow to translate empty strings #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cfb2ed
Allow empty strings
VincentLanglet Jun 8, 2023
717cfe9
Merge branch 'main' into allow-empty-text
JanEbbing Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Translator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,16 +590,16 @@ private function validateAndAppendTexts(array &$params, $texts)
{
if (is_array($texts)) {
foreach ($texts as $text) {
if (!is_string($text) || strlen($text) === 0) {
if (!is_string($text)) {
throw new DeepLException(
'texts parameter must be a non-empty string or array of non-empty strings',
'texts parameter must be a string or array of strings',
);
}
}
} else {
if (!is_string($texts) || strlen($texts) === 0) {
if (!is_string($texts)) {
throw new DeepLException(
'texts parameter must be a non-empty string or array of non-empty strings',
'texts parameter must be a string or array of strings',
);
}
}
Expand Down
13 changes: 12 additions & 1 deletion tests/TranslateTextTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function testInvalidTargetLanguage(?ClientInterface $httpClient)

public function invalidTextParameters(): array
{
return [[''], [['']]];
return [[42], [[42]]];
}

/**
Expand Down Expand Up @@ -120,6 +120,17 @@ public function testTranslateWithRetries(?ClientInterface $httpClient)
$this->assertGreaterThan(1.0, $timeAfter - $timeBefore);
}

/**
* @dataProvider provideHttpClient
*/
public function testEmptyText(?ClientInterface $httpClient)
{
$this->needsRealServer();
$translator = $this->makeTranslator([TranslatorOptions::HTTP_CLIENT => $httpClient]);

$this->assertEquals('', $translator->translateText('', null, 'de')->text);
}

/**
* @dataProvider provideHttpClient
*/
Expand Down