Import dependencies of base checks on demand #19781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
steveny91
approved these changes
Mar 6, 2025
sarah-witt
approved these changes
Mar 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Lazily import requests-related objects * refactor: move imports of prometheus inside functions using it * fix lint * add changelog * docs * update changelog --------- Co-authored-by: Pierre Gimalac <pierre.gimalac@datadoghq.com>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Lazily import requests-related objects * refactor: move imports of prometheus inside functions using it * fix lint * add changelog * docs * update changelog --------- Co-authored-by: Pierre Gimalac <pierre.gimalac@datadoghq.com> 2561323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before
from datadog_checks.base import AgentCheckwould trigger the import of:requestsprometheus_clientAfter
Only checks that need HTTP and Prometheus functionality perform these imports.
Motivation
Reduce the Agent's memory footprint.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged