Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump integrations-core pin #34883

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Bump integrations-core pin #34883

merged 1 commit into from
Mar 7, 2025

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Mar 7, 2025

What does this PR do?

Have the agent use DataDog/integrations-core#19781

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 58080630 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor cbf55473bb455e8ff016e285f79614aa1a848c8d

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.01MB ⚠️ 821.73MB 821.72MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 821.73MB 821.72MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 812.65MB 812.63MB 0.50MB
datadog-agent-amd64-deb 0.01MB ⚠️ 811.94MB 811.93MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 802.87MB 802.86MB 0.50MB
datadog-heroku-agent-amd64-deb 0.01MB ⚠️ 440.52MB 440.51MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.29MB 39.29MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.37MB 39.37MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.37MB 39.37MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.82MB 37.82MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.13MB 62.13MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.20MB 62.20MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.20MB 62.20MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.35MB 59.35MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.42MB 59.42MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 785.34MiB 801.8MiB 191.49MiB 202.62MiB
static_quality_gate_agent_deb_arm64 776.67MiB 793.14MiB 173.68MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 785.33MiB 801.79MiB 193.49MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 776.66MiB 793.09MiB 175.7MiB 186.44MiB
static_quality_gate_agent_suse_amd64 785.33MiB 801.81MiB 193.49MiB 205.03MiB
static_quality_gate_agent_suse_arm64 776.66MiB 793.14MiB 175.7MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.55MiB 47.67MiB 9.73MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.14MiB 46.27MiB 8.44MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.55MiB 47.67MiB 9.74MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.55MiB 47.67MiB 9.74MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.32MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.67MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.32MiB 69.0MiB 14.92MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.67MiB 66.4MiB 12.86MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.32MiB 69.0MiB 14.92MiB 24.8MiB
static_quality_gate_docker_agent_amd64 870.47MiB 886.12MiB 292.85MiB 304.21MiB
static_quality_gate_docker_agent_arm64 885.09MiB 900.79MiB 279.15MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.04GiB 1.06GiB 367.97MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 350.22MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.69MiB 55.78MiB 17.23MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.33MiB 54.45MiB 16.11MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.77MiB 274.78MiB 106.25MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.71MiB 290.82MiB 101.09MiB 111.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6510c3a7-9611-4582-abfc-6a7c4d3618cb

Baseline: cbf5547
Comparison: ed6d7b1
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization -6.66 [-6.73, -6.59] 1 Logs bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.07 [-0.13, +0.27] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.72, +0.84] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.83, +0.92] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.80, +0.85] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.30, +0.28] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.69, +0.64] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.87, +0.70] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.16 [-0.92, +0.60] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.28 [-1.13, +0.57] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.29 [-0.75, +0.18] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.92 [-0.99, -0.86] 1 Logs
quality_gate_logs % cpu utilization -1.61 [-4.31, +1.09] 1 Logs
quality_gate_idle_all_features memory utilization -4.16 [-4.30, -4.03] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -6.66 [-6.73, -6.59] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@iliakur iliakur marked this pull request as ready for review March 7, 2025 19:09
@iliakur iliakur requested review from a team as code owners March 7, 2025 19:09
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Mar 7, 2025
@FlorentClarret
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 7, 2025

View all feedbacks in Devflow UI.
2025-03-07 19:15:05 UTC ℹ️ Start processing command /merge


2025-03-07 19:15:13 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-07 19:16:11 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 32m.


2025-03-07 19:41:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e063c05 into main Mar 7, 2025
287 of 291 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ik/bump-ints-core branch March 7, 2025 19:41
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants