Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync WMI utils from dd-agent to datadog-checks-base #1897

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Sync WMI utils from dd-agent to datadog-checks-base #1897

merged 2 commits into from
Jul 17, 2018

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Jul 17, 2018

What does this PR do?

Imports one fix and two functions from the dd-agent version of WMI helpers to the checks-base package.

Ports https://github.com/DataDog/dd-agent/pull/3618/files and DataDog/dd-agent#3378 to datadog-checks-base

Motivation

Keep everything in sync.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@nmuesch nmuesch requested a review from a team as a code owner July 17, 2018 16:13
@nmuesch nmuesch changed the title Import WMI updates from dd-agent Sync WMI utils from dd-agent to datadog-checks-base Jul 17, 2018
@nmuesch nmuesch mentioned this pull request Jul 17, 2018
Merged
gzussa
gzussa approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @olivielpeau is ok them so am i 😺

@nmuesch nmuesch merged commit 1377613 into master Jul 17, 2018
@nmuesch nmuesch deleted the nick/import_wmi_updates_to_base branch July 17, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

@derekwbrown derekwbrown derekwbrown approved these changes

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmuesch @gzussa @derekwbrown @olivielpeau