Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] add additional calculator types. New calculators needed to #3378

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

derekwbrown
Copy link
Contributor

process the data requested in this support card

https://trello.com/c/y9KrekoF/170-how-to-get-usable-avgdisksecperread-from-win32perfrawdataperfdiskphysicaldisk

What does this PR do?

Adds two new calculator types for computing values returned by WMI

Motivation

Customer request.

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short comment on docs, but other than that looks good! 👌

Let's check with the customer that this works as expected :)

@calculator(5571840)
def calculate_perf_counter_100ns_queuelen_type(previous, current, property_name):
"""
PERF_COUNTER_100NS_QUEUELEN_TYPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the docs on msdn are slowly being retired, but here's what I found on PERF_COUNTER_100NS_QUEUELEN_TYPE: https://msdn.microsoft.com/en-us/library/aa392905(v=vs.85).aspx

Could you include the short description in the comment here?

Average length of a queue to a resource over time in 100 nanosecond units.

@olivielpeau
Copy link
Member

olivielpeau commented Jun 7, 2017

Actually there are a few formatting issues (flake8), could you check that too?

@derekwbrown derekwbrown merged commit d18a687 into master Jun 28, 2017
@hush-hush hush-hush deleted the db/new_calculators branch July 10, 2017 08:53
@hush-hush hush-hush added this to the 5.15 milestone Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants