Remove utils that are available in datadog_checks #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e300dc to
6422847
Compare
f5356e9 to
044bd54
Compare
olivielpeau
approved these changes
Jun 20, 2018
|
@olivielpeau I was able to build the Agent and tested the imports continue to work on Windows and Linux specifically. Could someone from croissant take another pass? Would love to get this merged for the next minor release. |
olivielpeau
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
LGTM!
This PR should be safe to merge because Nick has been able to confirm that:
- all checks in 5.25 are already importing from these utils from datadog_checks_base
- except wmi_check, which has been updated on master, and for which Nick's double checked the related wmi utils in datadog_checks_base are up-to-date with the ones in dd-agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Remove a lot of code that is already available in datadog_checks_base.
Motivation
Keep only one set of code to make things easier to update.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
The way the imports work on the datadog_checks lib means that in order to test the wmi checks, it requires the win32 extension to be available. So we now conditionally import the wmi_calculator stuff so that it will pass if it doesn't exist. This should cause the tests to fail if we are on a windows machine, but be properly skipped if we aren't (had to do this to get Travis to be 🆗 )
This PR assumes this is in datadog-checks-base DataDog/integrations-core#1897