-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement regex for consumer_groups #14382
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
<CONSUMER_NAME_1>: | ||
<TOPIC_NAME_1>: [0, 1, 4, 12] | ||
<CONSUMER_NAME_2>: | ||
<TOPIC_NAME_2>: [] | ||
<CONSUMER_NAME_3>: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful to provide some examples of proper regexes here - particularly to provide examples of keys like this in yaml (do they need to be wrapped in "
or can you drop a raw regex as a key)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mwarkentin sorry just saw this. I've made a PR changing these examples to be more realistic: #14533
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yzhan289 !
I was also wondering if you know when this will be released? Seems like datadog-agent is still on the 2.16.x series for the kafka consumer integration? |
The integration will be a part of Agent 7.45.0, which will be released in the upcoming few weeks. |
Remake of #14193
What does this PR do?
This PR adds a new config option called
consumer_groups_regex
. This functions similarly toconsumer_groups
to allow configuration of consumer groups, topics, and partitions to monitor, however this allows regex strings to be used.This will be merged to
master
after #13918 is merged.Motivation
Feature request
Additional Notes
When
monitor_unlisted_consumer_groups
is set toTrue
, then bothconsumer_groups
andconsumer_groups_regex
will be ignored.When
consumer_groups
andconsumer_groups_regex
are both used, then consumer groups from both config options will be collected.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.