Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement regex for consumer_groups #14193

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Mar 20, 2023

What does this PR do?

This PR adds a new config option called consumer_groups_regex. This functions similarly to consumer_groups to allow configuration of consumer groups, topics, and partitions to monitor, however this allows regex strings to be used.

This will be merged to master after #13918 is merged.

Motivation

Feature request

Additional Notes

When monitor_unlisted_consumer_groups is set to True, then both consumer_groups and consumer_groups_regex will be ignored.

When consumer_groups and consumer_groups_regex are both used, then consumer groups from both config options will be collected.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #14193 (5a02fa3) into AI-2904/kafka-consumer-revamp (558307c) will increase coverage by 0.75%.
The diff coverage is 97.50%.

❗ Current head 5a02fa3 differs from pull request most recent head 3d7ac7e. Consider uploading reports for the commit 3d7ac7e to get more accurate results

Flag Coverage Δ
datadog_checks_dev 82.71% <ø> (+2.60%) ⬆️
kafka_consumer 95.74% <97.50%> (+2.35%) ⬆️
kubelet 90.80% <ø> (+0.11%) ⬆️
process 85.42% <ø> (+0.28%) ⬆️
temporal ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 force-pushed the 03-20-Implement_regex_for_consumer_groups branch from f0a757d to e0ae32a Compare March 21, 2023 01:32
@yzhan289
Copy link
Contributor Author

Skip legacy implementation from regex tests

@yzhan289 yzhan289 force-pushed the 03-20-Implement_regex_for_consumer_groups branch from 5090b93 to 372fcdd Compare March 23, 2023 22:55
@yzhan289 yzhan289 marked this pull request as ready for review March 23, 2023 22:55
@yzhan289 yzhan289 requested review from a team as code owners March 23, 2023 22:55
rtrieu
rtrieu previously approved these changes Mar 23, 2023
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I left some comments

@yzhan289 yzhan289 mentioned this pull request Mar 27, 2023
5 tasks
@yzhan289 yzhan289 force-pushed the 03-20-Implement_regex_for_consumer_groups branch 2 times, most recently from 8073c4b to 03d749e Compare March 29, 2023 15:20
@yzhan289 yzhan289 requested a review from FlorentClarret March 29, 2023 21:19
@yzhan289 yzhan289 force-pushed the 03-20-Implement_regex_for_consumer_groups branch from 03d749e to f18cb1c Compare March 30, 2023 18:06
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@yzhan289 yzhan289 force-pushed the 03-20-Implement_regex_for_consumer_groups branch from 49abf83 to 068084e Compare March 30, 2023 18:21
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

FlorentClarret
FlorentClarret previously approved these changes Mar 31, 2023
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Base automatically changed from AI-2904/kafka-consumer-revamp to master April 14, 2023 15:05
@yzhan289 yzhan289 dismissed stale reviews from FlorentClarret and rtrieu via 3d7ac7e April 14, 2023 15:05
@yzhan289 yzhan289 changed the base branch from master to AI-2904/kafka-consumer-revamp April 14, 2023 15:08
@yzhan289 yzhan289 changed the base branch from AI-2904/kafka-consumer-revamp to master April 14, 2023 15:09
@yzhan289 yzhan289 changed the base branch from master to AI-2904/kafka-consumer-revamp April 14, 2023 15:10
@yzhan289
Copy link
Contributor Author

Merging the revamp PR messed up the Git history of this PR, will investigate...

@yzhan289 yzhan289 marked this pull request as draft April 14, 2023 17:03
@yzhan289 yzhan289 closed this Apr 14, 2023
@yzhan289 yzhan289 deleted the 03-20-Implement_regex_for_consumer_groups branch April 14, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants