-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement regex for consumer_groups #14193
Implement regex for consumer_groups #14193
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
f0a757d
to
e0ae32a
Compare
Skip legacy implementation from regex tests |
5090b93
to
372fcdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I left some comments
kafka_consumer/datadog_checks/kafka_consumer/client/confluent_kafka_client.py
Outdated
Show resolved
Hide resolved
kafka_consumer/datadog_checks/kafka_consumer/client/confluent_kafka_client.py
Outdated
Show resolved
Hide resolved
kafka_consumer/datadog_checks/kafka_consumer/client/confluent_kafka_client.py
Outdated
Show resolved
Hide resolved
kafka_consumer/datadog_checks/kafka_consumer/client/confluent_kafka_client.py
Outdated
Show resolved
Hide resolved
kafka_consumer/datadog_checks/kafka_consumer/client/confluent_kafka_client.py
Outdated
Show resolved
Hide resolved
kafka_consumer/datadog_checks/kafka_consumer/client/confluent_kafka_client.py
Outdated
Show resolved
Hide resolved
kafka_consumer/datadog_checks/kafka_consumer/client/confluent_kafka_client.py
Outdated
Show resolved
Hide resolved
8073c4b
to
03d749e
Compare
03d749e
to
f18cb1c
Compare
The |
1 similar comment
The |
49abf83
to
068084e
Compare
The |
…ex_for_consumer_groups
…ex_for_consumer_groups
The |
…ex_for_consumer_groups
Merging the revamp PR messed up the Git history of this PR, will investigate... |
What does this PR do?
This PR adds a new config option called
consumer_groups_regex
. This functions similarly toconsumer_groups
to allow configuration of consumer groups, topics, and partitions to monitor, however this allows regex strings to be used.This will be merged to
master
after #13918 is merged.Motivation
Feature request
Additional Notes
When
monitor_unlisted_consumer_groups
is set toTrue
, then bothconsumer_groups
andconsumer_groups_regex
will be ignored.When
consumer_groups
andconsumer_groups_regex
are both used, then consumer groups from both config options will be collected.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.