Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kafka consumer consumer_groups_regex example to be more inform… #14533

Merged
merged 1 commit into from
May 8, 2023

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented May 8, 2023

…ative

What does this PR do?

This PR updates the example used in consumer_groups_regex to be more realistic in how the option can be used.

Motivation

#14382 (comment)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #14533 (66f37b2) into master (ccc8074) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
kafka_consumer 93.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 merged commit bb5563f into master May 8, 2023
@yzhan289 yzhan289 deleted the az/kafka-consumer-spec-yaml branch May 8, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants