Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health check to kube_* integrations #10668

Merged
merged 13 commits into from
Dec 7, 2022
Merged

Add health check to kube_* integrations #10668

merged 13 commits into from
Dec 7, 2022

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Nov 17, 2021

What does this PR do?

Adds a health check to the other kube_* integrations similar to the ones added in these PRs:

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@khewonc khewonc requested review from a team as code owners November 17, 2021 14:32
@ghost ghost added the documentation label Nov 17, 2021
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Feb 16, 2022 •
edited
Loading

Codecov Report

Merging #10668 (6cbfa19) into master (760fb50) will increase coverage by 1.43%.
The diff coverage is 93.25%.

Flag Coverage Δ
arangodb ?
calico ?
foundationdb ?
kube_dns 95.33% <92.59%> (-3.52%) ⬇️
kube_metrics_server 94.87% <92.72%> (-5.13%) ⬇️
kube_proxy 96.89% <94.20%> (-3.11%) ⬇️
teradata ?
traffic_server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt
Copy link
Contributor

/azp run PR Changes

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

clamoriniere
clamoriniere reviewed Oct 26, 2022
View reviewed changes
kube_dns/assets/service_checks.json Outdated Show resolved Hide resolved
kube_metrics_server/assets/service_checks.json Outdated Show resolved Hide resolved
kube_proxy/assets/service_checks.json Outdated Show resolved Hide resolved
clamoriniere
clamoriniere previously approved these changes Oct 26, 2022
View reviewed changes
@steveny91
Copy link
Contributor

@khewonc left small nit. If you can address it then I think we can get this merged in.

@khewonc @steveny91
Apply suggestions from code review
6cbfa19 
Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>
@steveny91 steveny91 merged commit af9ccbc into master Dec 7, 2022
@steveny91 steveny91 deleted the khewonc/add-health-check-kube-integrations branch December 7, 2022 20:44
github-actions bot pushed a commit that referenced this pull request Dec 7, 2022
@steveny91 @clamoriniere
Add health check to kube_* integrations (#10668)
b324615 
* Add health checks for kube_* integrations

* Add health_url to config specs

* Sync config models using ddev

* Fix example conf files

* Fix example confs again

* Run ddev validate models -s again

* ddev validate config/models

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>

Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com>
Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com> af9ccbc
@khewonc khewonc mentioned this pull request Dec 22, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

@clamoriniere clamoriniere clamoriniere left review comments

Assignees
No one assigned
Labels
containers documentation integration/kube_dns integration/kube_metrics_server integration/kube_proxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khewonc @sarah-witt @steveny91 @clamoriniere @hithwen