Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly use SSL options for health checks #9977

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

juliogreff
Copy link
Contributor

@juliogreff juliogreff commented Aug 25, 2021

What does this PR do?

Fixes a warning printed out when running the kube_scheduler and kube_controller_manager checks:

2021-08-24 08:34:49 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:124 in LogMessage) | kube_scheduler:f99c6bf7f3d8b29b | (http.py:338) | An unverified HTTPS request is being made to https://172.18.0.4:10259/healthz
2021-08-24 08:34:57 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:124 in LogMessage) | kube_controller_manager:ec28c854e9635dd6 | (http.py:338) | An unverified HTTPS request is being made to https://172.18.0.4:10257/healthz

It does so by setting defaults for tls_ignore_warning and tls_verify according to the other tls_* settings. If those aren't present, it sets empty defaults for those as well.

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #9977 (f759346) into master (669f56c) will increase coverage by 0.00%.
The diff coverage is 94.11%.

Flag Coverage Δ
kube_controller_manager 96.85% <94.11%> (-0.29%) ⬇️
kube_scheduler 96.20% <94.11%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can HTTP_CONFIG_REMAPPER not be used? https://datadoghq.dev/integrations-core/base/http/

@ofek ofek changed the title kube_scheduler/kube_controller_manager: pass SSL options for health checks Correctly use SSL options for health checks Aug 25, 2021
@ChristineTChen ChristineTChen merged commit 0c3a33d into master Aug 25, 2021
@ChristineTChen ChristineTChen deleted the juliogreff/kube-verify-tls branch August 25, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants