Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service check for K8s API Server components #9773

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

juliogreff
Copy link
Contributor

What does this PR do?

Adds kube_scheduler.up and kube_controller_manager.up service checks
for the Kube Scheduler and Kube Controller Manager, respectively. This
is to support the deprecation of some of the
kube_apiserver_controlplane.up service checks backed by the
ComponentStatus API. See
DataDog/datadog-agent#8577 for more context.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #9773 (3584f2c) into master (f2f285e) will increase coverage by 0.00%.
The diff coverage is 93.58%.

❗ Current head 3584f2c differs from pull request most recent head 8d5825b. Consider uploading reports for the commit 8d5825b to get more accurate results
| Flag | Coverage Δ | |
|---|---|---|
| kube_controller_manager | 97.14% <97.43%> (+0.08%) | ⬆️ |
| kube_scheduler | 96.41% <89.74%> (-1.67%) | ⬇️ |

Flags with carried forward coverage won't be shown. Click here to find out more.

Adds `kube_scheduler.up` and `kube_controller_manager.up` service checks
for the Kube Scheduler and Kube Controller Manager, respectively. This
is to support the deprecation of some of the
`kube_apiserver_controlplane.up` service checks backed by the
ComponentStatus API. See
DataDog/datadog-agent#8577 for more context.
@juliogreff juliogreff force-pushed the juliogreff/kube_apiserver_checks branch from 3584f2c to 8d5825b Compare July 27, 2021 10:59
@juliogreff juliogreff marked this pull request as ready for review July 27, 2021 11:08
@juliogreff juliogreff requested review from a team as code owners July 27, 2021 11:08
@juliogreff juliogreff merged commit e5a5b46 into master Jul 30, 2021
@juliogreff juliogreff deleted the juliogreff/kube_apiserver_checks branch July 30, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants