Skip to content

Issues: Cyfrin/2023-07-escrow

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

376 Open 502 Closed
376 Open 502 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

The Escrow contract can be initialized with the same buyer, seller and arbiter. ai-dup-Initialization finding-buyer-seller-arbitor-same-L low
#873 opened Aug 6, 2023 by codehawks-bot
Receipt can't be confirmed if seller is blacklisted by the asset finding-blocklisted-token high
#869 opened Aug 6, 2023 by codehawks-bot
Price invariants may break with negative rebasing tokena finding-rebase-token low
#867 opened Aug 6, 2023 by codehawks-bot
Use assembly to check for address(0) finding-assembly-check-zero-g gas
#865 opened Aug 6, 2023 by codehawks-bot
Constants in comparisons should appear on the left side ai-dup-Reordering finding-constants-left-g gas selected
#861 opened Aug 6, 2023 by codehawks-bot
NatSpec @param is missing ai-dup-Missing finding-natspec-param-i info
#859 opened Aug 6, 2023 by codehawks-bot
The nonReentrant modifier should occur before all other modifiers finding-non-reentrant-first-i info selected
#858 opened Aug 6, 2023 by codehawks-bot
NatSpec @return argument is missing ai-dup-Missing finding-natspec-return-i info selected
#856 opened Aug 6, 2023 by codehawks-bot
Not using Proxy pattern ai-dup-Deploying finding-minimal-proxy-over-escrow-i info
#854 opened Aug 6, 2023 by codehawks-bot
1
Malicious seller can grief buyer by using a USDC blacklisted address ai-dup-Griefing finding-blocklisted-token medium
#852 opened Aug 6, 2023 by codehawks-bot
Incompatible with some deflationary token finding-rebase-token low
#851 opened Aug 6, 2023 by codehawks-bot
Need to check for zero value tranfer of ERC20 tokens. ai-dup-Revert finding-zero-price-check low
#848 opened Aug 6, 2023 by codehawks-bot
1
Preventing Fund Lockup: Ensuring a Valid Arbiter in the Escrow Contract Constructor ai-dup-Escrow Vulnerabilities ai-dup-Funds ai-dup-Initialization ai-dup-Misconfiguration finding-zero-address-arbitor high
#846 opened Aug 6, 2023 by codehawks-bot
1
Lack of Input Validation - Price Parameter ai-dup-Validation finding-zero-price-check medium
#843 opened Aug 6, 2023 by codehawks-bot
2
Lack of Input Validation - Arbiter Addresses finding-zero-address-arbitor high
#842 opened Aug 6, 2023 by codehawks-bot
1
if (tokenContract.balanceOf(address(this)) < price) revert Escrow__MustDeployWithTokenBalance(); finding-balance-greater-than-price info selected
#839 opened Aug 6, 2023 by codehawks-bot
3
Informational suggestions finding-whitelist-i gas
#838 opened Aug 6, 2023 by codehawks-bot
1
Due to lack of the input validation to check whether or not buyer != arbiter, which allow a malicious buyer to be able to control the resolution of the dispute ai-dup-Funds ai-dup-Initialization ai-dup-Misconfiguration finding-buyer-seller-arbitor-same-L low
#835 opened Aug 6, 2023 by codehawks-bot
Buyer funds will stuck in contract ai-dup-Funds finding-zero-address-arbitor high
#834 opened Aug 6, 2023 by codehawks-bot
Buyer or Seller and arbiter can be set to the same address ai-dup-Escrow Vulnerabilities ai-dup-Funds ai-dup-Initialization finding-buyer-seller-arbitor-same-L low
#832 opened Aug 6, 2023 by codehawks-bot
deployement will fail for fee on transfer tokens ai-dup-failure finding-fee-on-transfer-l medium
#831 opened Aug 6, 2023 by codehawks-bot
The buyer of the Escrow contract can obtain all tokens contract balance finding-buyer-seller-arbitor-same-L medium
#830 opened Aug 6, 2023 by codehawks-bot
Use assembly to check for address(0) finding-assembly-check-zero-g gas
#827 opened Aug 6, 2023 by codehawks-bot
NatSpec @param and @return is missing ai-dup-Missing finding-natspec-param-i finding-natspec-return-i gas
#819 opened Aug 6, 2023 by codehawks-bot
Needless ReentrancyGuard wastes gas finding-uneeded-reentrant-modifier-g gas
#818 opened Aug 6, 2023 by codehawks-bot
3
ProTip! Updated in the last three days: updated:>2025-02-18.