Not using Proxy pattern

[codehawks-bot]

Not using Proxy pattern

Severity

Gas Optimization / Informational

Relevant GitHub Links

2023-07-escrow/src/EscrowFactory.sol

Lines 40 to 52 in 65a60eb

	Escrow escrow = new Escrow{salt: salt}(
	price,
	tokenContract,
	msg.sender,
	seller,
	arbiter,
	arbiterFee
	);
	if (address(escrow) != computedAddress) {
	revert EscrowFactory__AddressesDiffer();
	}
	emit EscrowCreated(address(escrow), msg.sender, seller, arbiter);
	return escrow;

Summary

Instead of using the proxy pattern for new Escrow contracts, the Escrow contract is deployed every time. This leads to unwanted gas expenditure.

Vulnerability Details

Although all Escrow contracts have the same code, a new contract is deployed everytime instead of deploying a single implementation followed by proxies.

    function newEscrow(
        uint256 price,
        IERC20 tokenContract,
        address seller,
        address arbiter,
        uint256 arbiterFee,
        bytes32 salt
    ) external returns (IEscrow) {
        .......
       Escrow escrow = new Escrow{salt: salt}(
            price,
            tokenContract,
            msg.sender, 
            seller,
            arbiter,
            arbiterFee
        );
        if (address(escrow) != computedAddress) {
            revert EscrowFactory__AddressesDiffer();
        }
        emit EscrowCreated(address(escrow), msg.sender, seller, arbiter);
        return escrow;
    }

Impact

Unwanted gas expenditure of about 400000 for every new escrow contract.

Tools Used

Foundry gas reported

Recommendations

Have a single escrow implementation contract and then deploy proxies.

[PatrickAlphaC]

Would need to double check on this...