Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informational suggestions #838

Open
codehawks-bot opened this issue Aug 6, 2023 · 1 comment
Open

Informational suggestions #838

codehawks-bot opened this issue Aug 6, 2023 · 1 comment

Comments

@codehawks-bot
Copy link

Informational suggestions

Severity

Gas Optimization / Informational

  • To mitigate against rogue token contracts being used in the Escrow protocol, implement measures such as token whitelisting, standardized token interfaces, safeguards on token transfers (to mitigate against untrusted callbacks), governance, upgradability.

  • should probably implement some cap on how much of the price(aka max fee), % wise, the arbiter may be allocated, to avoid/minimize chances of any dodgy dealings by rogue buyers trying to avoid paying too much(case where arbiter is linked to buyer as partner in crime...)

@PatrickAlphaC
Copy link
Member

We won't do whitelisting or max fee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants