-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sf 639 update contract upgrade message #256
fix: sf 639 update contract upgrade message #256
Conversation
* feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <amine.harty@consensys.net>
* feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: recoverAccount to avoid duplicate called on isUpgradeRequired * chore: hardcode cairo version 1 to constant CAIRO_VERSION * fix: findAddressIndex should return address if the address match either cairo0 or cairo{N} * fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not * chore: getCorrectContractAddress to return upgrade required attribute
* fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract
* fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base branch was changed.
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
This PR is to fix the update contract upgrade message
from
Waiting for transaction finalize...
to
Waiting for transaction to be finalised.