feat: add get starknet package #186

stanleyyconsensys · 2023-12-13T07:25:24Z

Description:
the PR is to add create a compilable wallet object that bridged to metamask starknet snap as a wallet options to support the get-starknet library

Detail implementation

create a class object named MetaMaskSnap to communicate with the snap via the window ethereum provider
create a class object named MetaMaskAccount to extend the Account class from starknet.js package, and overriding execute, signMessage, declare with MetaMaskSnap
create a class object named MetaMaskSigner to implement the SignerInterface interface from starknet.js package, and implement all member methods with MetaMaskSnap
create a class object named MetaMaskSnapWallet to implement the same API as IStarknetWindowObject

.github/workflows/publish-get-startnet-dev.yml

.github/workflows/publish-get-startnet.yml

sonarqubecloud · 2023-12-15T08:38:43Z

Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud · 2023-12-15T08:39:37Z

Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

packages/get-starknet/src/wallet.ts

mario-christopher · 2024-04-19T16:51:32Z

packages/get-starknet/README.md

+## How to use
+
+```javascript
+const walletInstance = new MetaMaskSnapWallet(


Is this example for the end consumer who will use the package ?
If yes, can the example cover a bit more usage, like:

How do we import the Package

How to used the imported objects

This is so that a Consumer will know whats to be done with the Package.

the package is for get-starknet, but no one else , i think we just need to indicate how get-starknet integrate is good enough

mario-christopher · 2024-04-19T17:08:10Z

packages/get-starknet/public/index.html

@@ -0,0 +1 @@
+<html></html>


What is the purpose of this HTML file ?
Can you add come comments in the Code file to describe its need and usage ?

it is to test the module fed working fine or not, i will keep it

mario-christopher · 2024-04-19T17:38:43Z

Should we update the Diagram of the PR to reflect the current design ? It still shows an NPM package. Should we instead describe the Fed.Module here ?

sonarqubecloud · 2024-05-01T03:56:26Z

Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-05-01T03:57:05Z

Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

* fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net>

* feat: change account contract to cairo 1 (#152) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <amine.harty@consensys.net> * feat: sf-542 block cairo0 (#153) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock * chore(deps): bump word-wrap from 1.2.3 to 1.2.5 (#131) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @adobe/css-tools from 4.2.0 to 4.3.1 (#132) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 7.3.8 to 7.5.2 (#130) Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: simplify snap logic * fix: replace hardcode class hash * fix: get version function * fix: recover account for getting upgraded cairo 1 address * feat: sf 549 update all method to support upgraded address (#188) * fix: recoverAccount to avoid duplicate called on isUpgradeRequired * chore: hardcode cairo version 1 to constant CAIRO_VERSION * fix: findAddressIndex should return address if the address match either cairo0 or cairo{N} * fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not * chore: getCorrectContractAddress to return upgrade required attribute * feat: sf-540 add account contract upgrade api (#189) * fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract * feat: sf-539 UI upgrade account (#191) * fix: test (#203) * chore: rebase * chore: update conflict * fix: lint issue * feat: sf 614 rebase (#246) * fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net> * chore: lint style * fix: lint issue * fix: yarn lock * chore: add update text * chore: update snap file * chore: update yarn.lock * chore: update snap sdk * fix: building and unit tests --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Amine Harty <amine.harty@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net>

* feat: change account contract to cairo 1 (#152) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <amine.harty@consensys.net> * feat: sf-542 block cairo0 (#153) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock * chore(deps): bump word-wrap from 1.2.3 to 1.2.5 (#131) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @adobe/css-tools from 4.2.0 to 4.3.1 (#132) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 7.3.8 to 7.5.2 (#130) Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: simplify snap logic * fix: replace hardcode class hash * fix: get version function * fix: recover account for getting upgraded cairo 1 address * feat: sf 549 update all method to support upgraded address (#188) * fix: recoverAccount to avoid duplicate called on isUpgradeRequired * chore: hardcode cairo version 1 to constant CAIRO_VERSION * fix: findAddressIndex should return address if the address match either cairo0 or cairo{N} * fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not * chore: getCorrectContractAddress to return upgrade required attribute * feat: sf-540 add account contract upgrade api (#189) * fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract * feat: sf-539 UI upgrade account (#191) * fix: test (#203) * chore: rebase * chore: update conflict * fix: lint issue * feat: sf 614 rebase (#246) * fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net> * chore: lint style * fix: lint issue * fix: yarn lock * chore: add update text * chore: update snap file * chore: update yarn.lock * fix: update waiting upgrade text * chore: update snap sdk * fix: building and unit tests * fix: manifest --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Amine Harty <amine.harty@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net>

* feat: change account contract to cairo 1 (#152) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <amine.harty@consensys.net> * feat: sf-542 block cairo0 (#153) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock * chore(deps): bump word-wrap from 1.2.3 to 1.2.5 (#131) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @adobe/css-tools from 4.2.0 to 4.3.1 (#132) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 7.3.8 to 7.5.2 (#130) Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: simplify snap logic * fix: replace hardcode class hash * fix: get version function * fix: recover account for getting upgraded cairo 1 address * feat: sf 549 update all method to support upgraded address (#188) * fix: recoverAccount to avoid duplicate called on isUpgradeRequired * chore: hardcode cairo version 1 to constant CAIRO_VERSION * fix: findAddressIndex should return address if the address match either cairo0 or cairo{N} * fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not * chore: getCorrectContractAddress to return upgrade required attribute * feat: sf-540 add account contract upgrade api (#189) * fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract * feat: sf-539 UI upgrade account (#191) * fix: test (#203) * chore: rebase * chore: update conflict * fix: lint issue * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts * feat: show upgrade dialog on get-starknet calls * feat: sf 614 rebase (#246) * fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net> * chore: upgrade modal link * chore: lint style * fix: lint issue * fix: yarn lock * chore: add update text * chore: update snap file * chore: update yarn.lock * style: prettier * fix: await missing in some upgradeRequired check * test: updated unit testing associated to get-starknet * fix: adapted text of the upgradeRequestModal * style: lint * chore: update snap sdk * fix: manifest * test: fix on executTxn.test.ts * fix: executeTxn with deployed cairov2 should not trigger deployment * fix: resolve local build get-starknet config issue --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Stanley Yuen <102275989+stanleyyconsensys@users.noreply.github.com> Co-authored-by: Amine Harty <amine.harty@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

stanleyyconsensys added 5 commits December 12, 2023 15:30

feat: add get-starknet package

ebc8067

feat: test cicd

ea84739

feat: test cicd

f450ab0

fix: test ccid

344749f

feat: update read me

7472245

stanleyyconsensys changed the title ~~Feat: add get starknet package~~ feat: add get starknet package Dec 13, 2023

fix: update lint style

0cc933f

wantedsystem reviewed Dec 13, 2023

View reviewed changes

.github/workflows/publish-get-startnet-dev.yml Outdated Show resolved Hide resolved

.github/workflows/publish-get-startnet.yml Outdated Show resolved Hide resolved

stanleyyconsensys added 2 commits December 14, 2023 11:07

fix: update comment

d42eb49

fix: update lint checking

998a4b7

stanleyyconsensys marked this pull request as ready for review December 14, 2023 09:21

stanleyyconsensys requested a review from a team as a code owner December 14, 2023 09:21

stanleyyconsensys requested review from Julink-eth and wantedsystem December 14, 2023 09:21

fix: update readme

fc04076

fix: export get-starknet type and interface

84232a1

stanleyyconsensys commented Mar 7, 2024

View reviewed changes

packages/get-starknet/src/wallet.ts Show resolved Hide resolved

stanleyyconsensys commented Mar 7, 2024

View reviewed changes

packages/get-starknet/src/wallet.ts Outdated Show resolved Hide resolved

stanleyyconsensys added 10 commits March 26, 2024 09:39

chore: add webpack bundler to get-starknet

2d99c7f

Merge branch 'main' into feat/add-get-starknet-package

03cdaf5

chore: update get-starknet yarn

38225b8

chore: update output path for get-starknet

0fff308

fix: incorrect request result

f77ce67

fix: update request method result for get-starkent

a40dc3c

Merge branch 'main' into feat/add-get-starknet-package

ff3889a

chore: update readme

e9047b1

chore: remove unuse files

8bc5ab5

chore: remove publish script in get-starknet package

adbfae9

stanleyyconsensys added 6 commits March 28, 2024 13:13

chore: remove CICD for get-starknet package

456c329

Merge branch 'main' into feat/add-get-starknet-package

e029839

fix: update typo in get-starknet

a2e3a61

fix: update wallet default version to wildcard

b247477

feat: update package

3c390d8

Merge branch 'main' into feat/add-get-starknet-package

8eaee5b

mario-christopher reviewed Apr 19, 2024

View reviewed changes

stanleyyconsensys added 2 commits April 22, 2024 09:58

fix: update root domain

5ac9bef

fix: update testing script name

507fe6e

mario-christopher previously approved these changes May 1, 2024

View reviewed changes

Merge branch 'main' into feat/add-get-starknet-package

c9bac6e

stanleyyconsensys dismissed mario-christopher’s stale review via c9bac6e May 1, 2024 03:51

stanleyyconsensys merged commit c44c00d into main May 1, 2024
4 checks passed

stanleyyconsensys deleted the feat/add-get-starknet-package branch May 1, 2024 04:14

github-actions bot mentioned this pull request May 1, 2024

chore: release main #238

Merged

github-actions bot mentioned this pull request Jun 20, 2024

chore: release main #252

Merged

This was referenced Nov 26, 2024

chore: release main #439

Closed

chore: release main #440

Closed

chore: release main #441

Closed

chore: release main #446

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add get starknet package #186

feat: add get starknet package #186

stanleyyconsensys commented Dec 13, 2023 •

edited

Loading

sonarqubecloud bot commented Dec 15, 2023

sonarqubecloud bot commented Dec 15, 2023

mario-christopher Apr 19, 2024 •

edited

Loading

stanleyyconsensys Apr 30, 2024 •

edited

Loading

mario-christopher Apr 19, 2024

stanleyyconsensys Apr 30, 2024

mario-christopher commented Apr 19, 2024

sonarqubecloud bot commented May 1, 2024

sonarqubecloud bot commented May 1, 2024

		@@ -0,0 +1 @@
		<html></html>

feat: add get starknet package #186

feat: add get starknet package #186

Conversation

stanleyyconsensys commented Dec 13, 2023 • edited Loading

sonarqubecloud bot commented Dec 15, 2023

Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

sonarqubecloud bot commented Dec 15, 2023

Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

mario-christopher Apr 19, 2024 • edited Loading

Choose a reason for hiding this comment

stanleyyconsensys Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

mario-christopher Apr 19, 2024

Choose a reason for hiding this comment

stanleyyconsensys Apr 30, 2024

Choose a reason for hiding this comment

mario-christopher commented Apr 19, 2024

sonarqubecloud bot commented May 1, 2024

Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

sonarqubecloud bot commented May 1, 2024

Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

stanleyyconsensys commented Dec 13, 2023 •

edited

Loading

mario-christopher Apr 19, 2024 •

edited

Loading

stanleyyconsensys Apr 30, 2024 •

edited

Loading