feat: sf-542 block cairo0 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stanleyyconsensys
commented
Sep 29, 2023
- add blocking on snap method [signMessage, sendTransaction, extractPublicKey, extractPrivateKey, verifySignedMessage, estimateFee]
- add test cases
- update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case
- add blocking on snap methods - add test case
… feat/sf-542-block-cairo0
|
[consensys_starknet-snap-starknet-snap] Kudos, SonarCloud Quality Gate passed!
|
|
[consensys_starknet-snap-wallet-ui] Kudos, SonarCloud Quality Gate passed!
|
stanleyyconsensys
added a commit
that referenced
this pull request
Jun 20, 2024
* feat: change account contract to cairo 1 (#152) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <amine.harty@consensys.net> * feat: sf-542 block cairo0 (#153) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock * chore(deps): bump word-wrap from 1.2.3 to 1.2.5 (#131) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @adobe/css-tools from 4.2.0 to 4.3.1 (#132) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 7.3.8 to 7.5.2 (#130) Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: simplify snap logic * fix: replace hardcode class hash * fix: get version function * fix: recover account for getting upgraded cairo 1 address * feat: sf 549 update all method to support upgraded address (#188) * fix: recoverAccount to avoid duplicate called on isUpgradeRequired * chore: hardcode cairo version 1 to constant CAIRO_VERSION * fix: findAddressIndex should return address if the address match either cairo0 or cairo{N} * fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not * chore: getCorrectContractAddress to return upgrade required attribute * feat: sf-540 add account contract upgrade api (#189) * fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract * feat: sf-539 UI upgrade account (#191) * fix: test (#203) * chore: rebase * chore: update conflict * fix: lint issue * feat: sf 614 rebase (#246) * fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net> * chore: lint style * fix: lint issue * fix: yarn lock * chore: add update text * chore: update snap file * chore: update yarn.lock * chore: update snap sdk * fix: building and unit tests --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Amine Harty <amine.harty@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net>
stanleyyconsensys
added a commit
that referenced
this pull request
Jun 20, 2024
* feat: change account contract to cairo 1 (#152) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <amine.harty@consensys.net> * feat: sf-542 block cairo0 (#153) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock * chore(deps): bump word-wrap from 1.2.3 to 1.2.5 (#131) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @adobe/css-tools from 4.2.0 to 4.3.1 (#132) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 7.3.8 to 7.5.2 (#130) Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: simplify snap logic * fix: replace hardcode class hash * fix: get version function * fix: recover account for getting upgraded cairo 1 address * feat: sf 549 update all method to support upgraded address (#188) * fix: recoverAccount to avoid duplicate called on isUpgradeRequired * chore: hardcode cairo version 1 to constant CAIRO_VERSION * fix: findAddressIndex should return address if the address match either cairo0 or cairo{N} * fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not * chore: getCorrectContractAddress to return upgrade required attribute * feat: sf-540 add account contract upgrade api (#189) * fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract * feat: sf-539 UI upgrade account (#191) * fix: test (#203) * chore: rebase * chore: update conflict * fix: lint issue * feat: sf 614 rebase (#246) * fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net> * chore: lint style * fix: lint issue * fix: yarn lock * chore: add update text * chore: update snap file * chore: update yarn.lock * fix: update waiting upgrade text * chore: update snap sdk * fix: building and unit tests * fix: manifest --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Amine Harty <amine.harty@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net>
khanti42
added a commit
that referenced
this pull request
Jun 21, 2024
* feat: change account contract to cairo 1 (#152) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <amine.harty@consensys.net> * feat: sf-542 block cairo0 (#153) * feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock * chore(deps): bump word-wrap from 1.2.3 to 1.2.5 (#131) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @adobe/css-tools from 4.2.0 to 4.3.1 (#132) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 7.3.8 to 7.5.2 (#130) Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: simplify snap logic * fix: replace hardcode class hash * fix: get version function * fix: recover account for getting upgraded cairo 1 address * feat: sf 549 update all method to support upgraded address (#188) * fix: recoverAccount to avoid duplicate called on isUpgradeRequired * chore: hardcode cairo version 1 to constant CAIRO_VERSION * fix: findAddressIndex should return address if the address match either cairo0 or cairo{N} * fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not * chore: getCorrectContractAddress to return upgrade required attribute * feat: sf-540 add account contract upgrade api (#189) * fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract * feat: sf-539 UI upgrade account (#191) * fix: test (#203) * chore: rebase * chore: update conflict * fix: lint issue * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts * feat: show upgrade dialog on get-starknet calls * feat: sf 614 rebase (#246) * fix: address field error (#234) * fix: fix address field error * chore: release main (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: bump starknetjs to 6.7.0 (#219) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: sf 612 add alchemy provider (#236) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: update mainnet-url * feat: sf 613 add cicd support for alchemy (#237) * feat: bump starknetjs to 6.6.0 * chore: remove unuse script * chore: add default config * chore: remove patching * chore: update library version * chore: update getStarkName * feat: add alchemy provider * fix: add cicd pipeline * feat: add get starknet package (#186) * feat: add get-starknet package * feat: test cicd * feat: test cicd * fix: test ccid * feat: update read me * fix: update lint style * fix: update comment * fix: update lint checking * fix: update readme * fix: export get-starknet type and interface * chore: add webpack bundler to get-starknet * chore: update get-starknet yarn * chore: update output path for get-starknet * fix: incorrect request result * fix: update request method result for get-starkent * chore: update readme * chore: remove unuse files * chore: remove publish script in get-starknet package * chore: remove CICD for get-starknet package * fix: update typo in get-starknet * fix: update wallet default version to wildcard * feat: update package * fix: update root domain * fix: update testing script name * chore: release main (#238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update yarn lock (#240) * fix: get-starknet execute txn not working in firefox (#242) * fix: firefox undefined issue * fix: lint style * feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: methods signature * test: make existing tests pass successfully * fix: rollback check CairoVersion not needed * fix: lint * fix: contractCallData format in massagedTransaction * fix: upgrade function detection in getMassagedTransactions filtering method * refactor: ugrade detection mechanism similar to transfer based on method hex definition * test: adapt constants.test.ts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florin Dzeladini <florin.dzeladini@consensys.net> * chore: upgrade modal link * chore: lint style * fix: lint issue * fix: yarn lock * chore: add update text * chore: update snap file * chore: update yarn.lock * style: prettier * fix: await missing in some upgradeRequired check * test: updated unit testing associated to get-starknet * fix: adapted text of the upgradeRequestModal * style: lint * chore: update snap sdk * fix: manifest * test: fix on executTxn.test.ts * fix: executeTxn with deployed cairov2 should not trigger deployment * fix: resolve local build get-starknet config issue --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Stanley Yuen <102275989+stanleyyconsensys@users.noreply.github.com> Co-authored-by: Amine Harty <amine.harty@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.