Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleCalorimeter in openPMD #3559

Conversation

franzpoeschel
Copy link
Contributor

#3357

TODO

  • Rewrite normal calorimeter output in openPMD
  • Set some of the attributes correctly. For some of them I'll need the help of a plugin user, I marked them with @todo in the code.
  • Remove the libsplash output, currently both are written.
  • Checkpointing. How do I trigger a calorimeter checkpoint? I don't see a command line option for that.
  • More testing.
  • The Bremsstrahlung example has a Python analysis script. I suppose that that one should be updated too.

psychocoderHPC and others added 30 commits October 19, 2020 09:44
…Pi/add_openPMD_adios2_module_hemera

update openPMD and ADIOS module
…/fix-pmaccComplexNumberMath

Fix complex math abs and abs2 issues
…/docs-fixProbeFieldNames

Fix the name of probe fieldE and fieldB attribute in docs
This improves error output in case the command throws (e.g. inside alpaka).
This only affects the case when PMACC_BLOCKING_KERNEL is enabled, as the macro
itself is only used in this case.
…hel/fix-deactivate-support-for-adios1

Deactivate support for writing to ADIOS1 via the openPMD plugin
…/topic-pmaccImproveKernelErrorOutput

Improve output of kernel errors in PMacc with PMACC_BLOCKING_KERNEL=ON
fix missing `"` intrudzced with ComputationalRadiationPhysics#3327
…hel/update-openpmd-version

Update required openPMD version to 0.12.0
…Pi/fix_ADIOS1_2_conflict_hemera_module

add both adios and adios2 module on hemera
…hel/update-iteration-close

Use Iteration::close() in openPMD plugin
…ature-2020-09_ionizationCurrent

Fix Ionization Current
…s of cells

Motivation is described in ComputationalRadiationPhysics#3391, and user functors are already required to be
evaluatable at any point. Thus, the change should merely improve accuracy and
potentially avoid some rounding issues, without breaking anything
This class is never used.
The openPMD plugin uses patches from openPMD API
…/topic-clarifyDensityProfileComments

Improve clarity of comments concerning density calculation and profile interface
…/topic-evaluateFreeFormulaDensityAtCentersOfCells

Modify FreeFormulaImpl density profile to evalute a functor in centers of cells
switch from the dev version of openpmd-api 0.12.0-dev to the las
trelease
Some pushers were not enabled in any example, and so were not compile-time tested
…rHPC/topic-ciUseOpenPMD0.12.0

CI test with openpmd-api 0.12.0
…/topic-clarifyTemperatureComments

Clarify comments for generating momentums based on temperature
Required changes to support HIP.

Note: HIP can currently not enabled via `pic-build`, this will be
allowed when all requirements (alpaka, cupla and mallocMC) support the latest HIP version.
psychocoderHPC and others added 28 commits March 5, 2021 14:57
Allow the user to tune the number of worker/threads uses to compute the
current.
The worker multiplier is now part of the strategy used to configure the
compute current task and kernel behavior.

The default for CUDA devices is changed from `2` to `1` with this PR.
This will result in a better prformance for all devices with compute
architecture 6.0+. On kepler the performance will be slightly reduced.
Update documentation of the example and mention new compute current
strategies.
With ComputationalRadiationPhysics#3502 we forgot to update the tool `newVersion.sh`
…rHPC/fix-toolNewVersion

fix tool `newVersion.sh`
…rHPC/topic-exposeComputeCurrentWorkerMultiplier

expose compute current worker multiplier
…rHPC/topic-mergeMainlineChangesBack

merge mainline changes back into dev
We missed to update the version after our last release.
…saac-glm-compatibility

Adds compatibility to isaac glm PR
…rHPC/topic-devVErsionIncrease

update version to 0.6.0-dev
…hel/topic-json-extended

openPMD plugin: Extended JSON patterns
…un-time

This commit does not change the user interface of PIConGPU.
The only difference is that custom current deposition functors declared in .param files are no longer allowed.
It made internal changes necessary for a full transition of this parameter towards run-time.
…hel/openpmd-backend-installation-instructions

Add installation instructions for ADIOS2 and HDF5 backends of openPMD API
…/doc-addAoFDTDToPmlParam

Add missing artibrary order solver to the list of PML-enabled field solvers
…/topic-prepareRunTimeCurrentInterpolation

Switch internal handling of current deposition from compile-time to run-time
Fix that each file that contains `cmakeFlags` within the name is checked for EOF white spaces.
In ComputationalRadiationPhysics#3416 png files were checked, the result is a failing CI.
…rHPC/fix-whiteSpaceFix

fix EOF whitespace test
…/topic-removeUnusedEnumFieldType

Remove unused enum picongpu::FieldType
@franzpoeschel
Copy link
Contributor Author

Wrong base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.