Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing of libsplash dependency #3357

Closed
6 tasks done
psychocoderHPC opened this issue Sep 23, 2020 · 18 comments · Fixed by #3566
Closed
6 tasks done

Removing of libsplash dependency #3357

psychocoderHPC opened this issue Sep 23, 2020 · 18 comments · Fixed by #3566
Assignees
Labels
component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API
Milestone

Comments

@psychocoderHPC
Copy link
Member

psychocoderHPC commented Sep 23, 2020

I will remove the dependency libsplash latest on 31.10.2020.

The following plugins should be updated before:

@PrometheusPi @HighIander Who can do this, who knows the plugin best?

@psychocoderHPC psychocoderHPC added refactoring code change to improve performance or to unify a concept but does not change public API component: plugin in PIConGPU plugin labels Sep 23, 2020
@PrometheusPi
Copy link
Member

@psychocoderHPC I will do the radiation plugin - ParticleCalorimeter is probably best handled by @n01r - but he has no time.

@sbastrakov
Copy link
Member

We discussed offline with @psychocoderHPC , I could take on some work on this, at start of October. Do not have a particular preference.

@sbastrakov
Copy link
Member

Good note on updating the docs when all this is implemented: #3361 (comment)

@steindev
Copy link
Member

libsplash does not compile anymore against a recent version of the HDF5 library. We really should get this done. Volunteers?

@franzpoeschel
Copy link
Contributor

If there are still unassigned plugins to convert, I think I can take one. Which one would be the best?

@steindev
Copy link
Member

If there are still unassigned plugins to convert, I think I can take one. Which one would be the best?

Wonderful! How about ParticleCalorimeter? Thank you so much!

@steindev
Copy link
Member

UPDATE: Just chatted with @PrometheusPi. He is working on the Radiation Plugin.

@sbastrakov
Copy link
Member

So with these updates only density profile is not assigned? If so, i will take it

@franzpoeschel
Copy link
Contributor

How about ParticleCalorimeter

Ok, sounds good. I'll have a look.

@psychocoderHPC
Copy link
Member Author

@franzpoeschel There is also a very simple plugin which used libsplash MacroParticleCounter for supercells

@sbastrakov
Copy link
Member

(Nevermind my deleted message, I can't read)

@PrometheusPi
Copy link
Member

@psychocoderHPC what will happen to PICToSplash after libSplash has been removed. Will it be still available and usable, as e.g. here?

@psychocoderHPC
Copy link
Member Author

@psychocoderHPC what will happen to PICToSplash after libSplash has been removed. Will it be still available and usable, as e.g. here?

This helper will be removed, there is an openPMD equivalent converter available.

@psychocoderHPC
Copy link
Member Author

@sbastrakov What ist he progress for the rewrite of the density profile?

@sbastrakov
Copy link
Member

@psychocoderHPC I still haven't done it. I made an example file to test the old implementation, but couldn't make it work actually due to missing attributes I don't understand. I guess I could skip that part and just replace it with openPMD using the PNG example you shared with me, that seems rather straightforward.

@sbastrakov
Copy link
Member

So 5/6 now.

@steindev
Copy link
Member

Note, once this is finished, we should also rewrite the dependency section of the manual (https://picongpu.readthedocs.io/en/latest/install/dependencies.html)

@steindev steindev linked a pull request Jul 22, 2021 that will close this issue
3 tasks
@psychocoderHPC
Copy link
Member Author

closed with #3744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants