Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libSplash still used in HDF5 density profile #3515

Closed
PrometheusPi opened this issue Feb 8, 2021 · 5 comments
Closed

libSplash still used in HDF5 density profile #3515

PrometheusPi opened this issue Feb 8, 2021 · 5 comments
Assignees
@sbastrakov
Labels
component: core in PIConGPU (core application) component: third party third party libraries that are shipped and/or linked question

Comments

@PrometheusPi
Copy link
Member

While investigating #3514, I have seen hat the (seldomly used) hdf5 density profile method still uses libSplash instead of openPMD-api.

This should be changed before the next release. @psychocoderHPC Or is this method already outdated (and shall be removed)?
@PrometheusPi PrometheusPi added question component: core in PIConGPU (core application) component: third party third party libraries that are shipped and/or linked labels Feb 8, 2021
@PrometheusPi PrometheusPi changed the title liSplash still used in HDF5 density profile libSplash still used in HDF5 density profile Feb 8, 2021
@sbastrakov
Copy link
Member

I am not familiar with this method. But probably to use openPMD API the input file has to be openPMD-annotated, while we currently take a raw hdf5 there? Maybe worth discussing on the dev meeting.

@sbastrakov
Copy link
Member

However, you are definitely right that it's weird having this place as only libSplash dependency.

@psychocoderHPC psychocoderHPC mentioned this issue Feb 10, 2021
Closed
6 tasks
@psychocoderHPC
Copy link
Member

I added this issue to #3357

@sbastrakov
Copy link
Member

Ah, sorry, I only wrote in the general issue and not here.

@sbastrakov sbastrakov mentioned this issue Jun 23, 2021
Merged
@sbastrakov
Copy link
Member

Implemented in #3655, closing.

@sbastrakov sbastrakov mentioned this issue Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbastrakov sbastrakov

Labels
component: core in PIConGPU (core application) component: third party third party libraries that are shipped and/or linked question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@psychocoderHPC @PrometheusPi @sbastrakov