Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic remove lib splash #3744

Merged
merged 6 commits into from
Sep 2, 2021
Merged

Topic remove lib splash #3744

merged 6 commits into from
Sep 2, 2021

Conversation

psychocoderHPC
Copy link
Member

@psychocoderHPC psychocoderHPC commented Aug 31, 2021 •
edited
Loading

fix #3357

Remove libSplash dependency and all tools based on libSPlash.

@psychocoderHPC psychocoderHPC added refactoring code change to improve performance or to unify a concept but does not change public API CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests labels Aug 31, 2021
@psychocoderHPC psychocoderHPC requested a review from a team August 31, 2021 15:39
@psychocoderHPC psychocoderHPC removed the CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests label Sep 1, 2021
@psychocoderHPC psychocoderHPC marked this pull request as ready for review September 1, 2021 13:58
PrometheusPi
PrometheusPi requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@PrometheusPi PrometheusPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pull request. Just a few questions remaining.

docs/source/install/profile.rst Show resolved Hide resolved
include/picongpu/plugins/radiation/Radiation.hpp Show resolved Hide resolved
src/tools/bin/pic2xdmf.py Show resolved Hide resolved
src/tools/bin/plot_chargeConservation_overTime.py Show resolved Hide resolved
@psychocoderHPC
Copy link
Member Author

@PrometheusPi I added your suggestions but keep pic2xdmf.py deleted.

@PrometheusPi PrometheusPi merged commit f3ae4de into ComputationalRadiationPhysics:dev Sep 2, 2021
@psychocoderHPC psychocoderHPC deleted the topic-removeLibSplash branch September 2, 2021 07:13
@psychocoderHPC psychocoderHPC mentioned this pull request Sep 2, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrometheusPi PrometheusPi PrometheusPi approved these changes

Assignees
No one assigned
Labels
refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@psychocoderHPC @PrometheusPi