Deactivate support for writing to ADIOS1 via the openPMD plugin #3395
Conversation
| @@ -140,6 +140,17 @@ namespace openPMD | |||
| log< picLog::INPUT_OUTPUT >( "openPMD: open file: %1%" ) % fullName; | |||
| openPMDSeries = std::unique_ptr<::openPMD::Series >( | |||
| new ::openPMD::Series( fullName, at, communicator, jsonConfig ) ); | |||
| if( openPMDSeries->backend() == "MPI_ADIOS1" ) | |||
| { | |||
| throw std::runtime_error(R"END( | |||
There was a problem hiding this comment.
It's C++11 syntax for multiline strings, see item 6 here.
There was a problem hiding this comment.
@franzpoeschel IS it possible to check in CMake that OpenPMD-api is at least build with ADIOS2 and/or HDF5?
There was a problem hiding this comment.
Yep, that should be doable. Will get to it.
There was a problem hiding this comment.
Recent commit does that. I left the runtime check in there.
|
@franzpoeschel we just discussed in the office that we should now disable reading ADIOS1 checkpoints as well, so to completely remove support of ADIOS1. However it seems from the code, that the exception thrown with this PRs change already affects reading, not just writing? (I don't have an old checkpoint to test it readily). |
|
Yep, that one should catch both reading and writing @sbastrakov. I think the fastest way to test would be by creating an ADIOS1 checkpoint. Quickly commenting out that check should do the trick. |
See here for a reasoning.