Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the syncPayload and meta outside the syncWithBlock #356

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Create the syncPayload and meta outside the syncWithBlock #356

merged 2 commits into from
Jul 25, 2024

Conversation

nzagorchev
Copy link
Contributor

Overview

Create the syncPayload and meta outside the syncWithBlock block. The block is executed on a separate queue.
This can cause crashes on syncCustomTemplates.

Implementation

Create the syncPayload and meta on the main thread (syncCustomTemplates needs to be called from the main thread) outside the block.

Notes

Crash at:

definitions[template.name] = templateData;
Thread 9: EXC_BAD_ACCESS (code=1, address=0xbeadde6d19e0)

Crash log:

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Triggered by Thread:  7

Thread 1::  Dispatch queue: com.clevertap.serialQueue:67Z-RRK-696Z
0   libsystem_kernel.dylib                 0x1b17dc10c semaphore_wait_trap + 8
1   libdispatch.dylib                      0x180134bc0 _dispatch_sema4_wait + 24
2   libdispatch.dylib                      0x180135234 _dispatch_semaphore_wait_slow + 128
3   CleverTapSDK                           0x101c0160c -[CleverTap syncRequest:logMessage:] + 464
4   CleverTapSDK                           0x101c012e8 __33-[CleverTap syncCustomTemplates:]_block_invoke + 404
5   CleverTapSDK                           0x101bdff44 __43-[CleverTap runSerialAsyncEnsureHandshake:]_block_invoke.167 + 40
6   libdispatch.dylib                      0x180132ee4 _dispatch_call_block_and_release + 24
7   libdispatch.dylib                      0x180134708 _dispatch_client_callout + 16
8   libdispatch.dylib                      0x18013c77c _dispatch_lane_serial_drain + 776
9   libdispatch.dylib                      0x18013d3dc _dispatch_lane_invoke + 392
10  libdispatch.dylib                      0x180149608 _dispatch_workloop_worker_thread + 768
11  libsystem_pthread.dylib                0x1b1834878 _pthread_wqthread + 284
12  libsystem_pthread.dylib                0x1b183363c start_wqthread + 8
Thread 2:
0   libsystem_pthread.dylib                0x1b1833634 start_wqthread + 0
Thread 3:
0   libsystem_pthread.dylib                0x1b1833634 start_wqthread + 0
Thread 4:
0   libsystem_pthread.dylib                0x1b1833634 start_wqthread + 0
Thread 5:: com.apple.uikit.eventfetch-thread
0   libsystem_kernel.dylib                 0x1b17dc190 mach_msg2_trap + 8
1   libsystem_kernel.dylib                 0x1b17ed258 mach_msg2_internal + 76
2   libsystem_kernel.dylib                 0x1b17e4398 mach_msg_overwrite + 540
3   libsystem_kernel.dylib                 0x1b17dc500 mach_msg + 20
4   CoreFoundation                         0x18039a4a8 __CFRunLoopServiceMachPort + 156
5   CoreFoundation                         0x180394ad4 __CFRunLoopRun + 1128
6   CoreFoundation                         0x180394254 CFRunLoopRunSpecific + 584
7   Foundation                             0x180b994bc -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 208
8   Foundation                             0x180b996e0 -[NSRunLoop(NSRunLoop) runUntilDate:] + 60
9   UIKitCore                              0x109e22714 -[UIEventFetcher threadMain] + 404
10  Foundation                             0x180bbede0 __NSThread__start__ + 704
11  libsystem_pthread.dylib                0x1b1838428 _pthread_start + 116
12  libsystem_pthread.dylib                0x1b1833648 thread_start + 8

Thread 7 Crashed::  Dispatch queue: com.apple.NSURLSession-delegate
0   libsystem_kernel.dylib                 0x1b17e3fa8 __pthread_kill + 8
1   libsystem_pthread.dylib                0x1b183812c pthread_kill + 256
2   libsystem_c.dylib                      0x18012873c abort + 124
3   libsystem_malloc.dylib                 0x18019a418 malloc_vreport + 912
4   libsystem_malloc.dylib                 0x18019a698 malloc_zone_error + 100
5   libsystem_malloc.dylib                 0x18018a49c nanov2_guard_corruption_detected + 40
6   libsystem_malloc.dylib                 0x180188374 nanov2_allocate_outlined + 344
7   libsystem_malloc.dylib                 0x180188b10 nanov2_calloc + 540
8   libxpc.dylib                           0x18007dfac _xpc_alloc + 28
9   libxpc.dylib                           0x18008cf20 _xpc_dictionary_insert + 424
10  libxpc.dylib                           0x18008d604 xpc_dictionary_set_uint64 + 52
11  libsystem_trace.dylib                  0x1800656d0 _os_activity_stream_entry_encode + 72
12  libsystem_trace.dylib                  0x1800654c0 _os_activity_stream_reflect + 448
13  libsystem_trace.dylib                  0x180073470 _os_log_impl_stream + 516
14  libsystem_trace.dylib                  0x180072f70 _os_log_impl_flatten_and_send + 6924
15  libsystem_trace.dylib                  0x18007144c _os_log + 148
16  libsystem_trace.dylib                  0x180073b50 _os_log_impl + 16
17  CFNetwork                              0x183d30ce0 0x183d2a000 + 27872
18  CFNetwork                              0x183d4c170 0x183d2a000 + 139632
19  libdispatch.dylib                      0x180132ee4 _dispatch_call_block_and_release + 24
20  libdispatch.dylib                      0x180134708 _dispatch_client_callout + 16
21  libdispatch.dylib                      0x18013c77c _dispatch_lane_serial_drain + 776
22  libdispatch.dylib                      0x18013d414 _dispatch_lane_invoke + 448
23  libdispatch.dylib                      0x180149608 _dispatch_workloop_worker_thread + 768
24  libsystem_pthread.dylib                0x1b1834878 _pthread_wqthread + 284
25  libsystem_pthread.dylib                0x1b183363c start_wqthread + 8

Backtrace:

* thread #9, queue = 'com.apple.root.user-initiated-qos', stop reason = EXC_BAD_ACCESS (code=1, address=0xbeadde6d19e0)
    frame #0: 0x000000018005b808 libobjc.A.dylib`objc_msgSend + 8
    frame #1: 0x0000000180501398 CoreFoundation`mdict_rehashd + 180
    frame #2: 0x00000001804fdd3c CoreFoundation`-[__NSDictionaryM setObject:forKeyedSubscript:] + 568
  * frame #3: 0x0000000102df38dc CleverTapSDK`__39-[CTCustomTemplatesManager syncPayload]_block_invoke(.block_descriptor=0x0000600000cc5b00, templateKey="template1", template=0x0000600000c84b70, stop=NO) at CTCustomTemplatesManager.m:221:9
    frame #4: 0x00000001803d6bf0 CoreFoundation`__NSDICTIONARY_IS_CALLING_OUT_TO_A_BLOCK__ + 16
    frame #5: 0x00000001805014ec CoreFoundation`__mdict_enumerateKeysAndObjectsWithOptionsUsingBlock_block_invoke + 112
    frame #6: 0x00000001804b1e54 CoreFoundation`____NSCollectionHandleConcurrentEnumerationIfSpecified_block_invoke + 136
    frame #7: 0x0000000103a55978 libdispatch.dylib`_dispatch_client_callout2 + 16
    frame #8: 0x0000000103a6cf50 libdispatch.dylib`_dispatch_apply_invoke_and_wait + 180
    frame #9: 0x0000000103a6c33c libdispatch.dylib`_dispatch_apply_with_attr_f + 1384
    frame #10: 0x0000000103a6c4dc libdispatch.dylib`dispatch_apply + 56
    frame #11: 0x00000001804b1d8c CoreFoundation`__NSCollectionHandleConcurrentEnumerationIfSpecified + 164
    frame #12: 0x00000001804fed00 CoreFoundation`-[__NSDictionaryM enumerateKeysAndObjectsWithOptions:usingBlock:] + 188
    frame #13: 0x0000000102df2ff0 CleverTapSDK`-[CTCustomTemplatesManager syncPayload](self=0x0000600000268de0, _cmd="syncPayload") at CTCustomTemplatesManager.m:177:5
    frame #14: 0x0000000102dcd1cc CleverTapSDK`__33-[CleverTap syncCustomTemplates:]_block_invoke(.block_descriptor=0x0000600000ca8f00) at CleverTap.m:4321:37
    frame #15: 0x0000000102dabf44 CleverTapSDK`__43-[CleverTap runSerialAsyncEnsureHandshake:]_block_invoke.167(.block_descriptor=0x0000600000ca8570) at CleverTap.m:750:13
    frame #16: 0x0000000103a540f0 libdispatch.dylib`_dispatch_call_block_and_release + 24
    frame #17: 0x0000000103a5593c libdispatch.dylib`_dispatch_client_callout + 16
    frame #18: 0x0000000103a5dbd8 libdispatch.dylib`_dispatch_lane_serial_drain + 916
    frame #19: 0x0000000103a5e91c libdispatch.dylib`_dispatch_lane_invoke + 420
    frame #20: 0x0000000103a6b2f8 libdispatch.dylib`_dispatch_root_queue_drain_deferred_wlh + 324
    frame #21: 0x0000000103a6a754 libdispatch.dylib`_dispatch_workloop_worker_thread + 488
    frame #22: 0x0000000101fb7814 libsystem_pthread.dylib`_pthread_wqthread + 284

@nzagorchev nzagorchev merged commit c3eb7d2 into custom_inapp_templates Jul 25, 2024
1 check passed
nzagorchev added a commit that referenced this pull request Aug 6, 2024
@nzagorchev
Custom in-app templates (#363)
8b642d2 
* [MC-1465] Custom templates define (Custom Templates Part 1) (#327)

* [MC-1467] Custom templates Sync (Custom Templates Part 2) (#329)

* [MC-1466] Custom templates data in inapp notification (Custom Templates Part 3) (#330)

* [MC-1468] Custom templates present and dismiss (Custom Templates Part 4) (#332)

* [MC-1470] Custom templates actions (Custom Templates Part 5) (#336)

* [MC-1649] Custom functions allow dictionaries (Custom Templates Part 6) (#337)

* [MC-1472] In-app actions js interface (Custom Templates Part 7) (#338)

* Implement custom templates file arguments (#348)

* Add template and template context debug descriptions (#351)

* [MC-1823] Fix html view controller presented before scene became active (#352)

* tvOS compatibility (#353)

* Add SDK version as window variable to the JS interface (#354)

* Create the syncPayload and meta outside the syncWithBlock (#356)

* Expose activeContextForTemplate (#357)

* [MC-1883] File download concurrency (#358)

* Enumerate synchronously (#359)

* Update docs, Changelog and README (#360)

* Update SPM (#362)

* Bump version to 7.0.0 (#361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-clevertap nishant-clevertap nishant-clevertap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzagorchev @nishant-clevertap