Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC-1466] Custom templates data in inapp notification (Custom Templates Part 3) #330

Merged

Conversation

nzagorchev
Copy link
Contributor

@nzagorchev nzagorchev commented May 10, 2024

Overview

Refactor CTInAppNotification. Move the prepare notification logic for downloading the image and landscape image to the CTInAppDisplayManager.
Extend CTInAppNotification and CTNotificationButton to support custom functions.

Implementation

  • Add CTCustomTemplateInAppData to the CTInAppNotification
  • Move the action from CTNotificationButton to the CTNotificationAction
  • Add CTCustomTemplateInAppData to the CTNotificationAction

Commits: efbc064, 60db706

@nzagorchev nzagorchev requested review from akashvercetti and vasct May 10, 2024 17:04
@nzagorchev nzagorchev marked this pull request as ready for review May 10, 2024 17:08
@nzagorchev nzagorchev force-pushed the custom_templates_inapp_notification branch from b3797ba to 557d842 Compare June 13, 2024 12:58
@nzagorchev nzagorchev force-pushed the custom_templates_inapp_notification branch from 557d842 to cfb5773 Compare June 13, 2024 13:06
@nzagorchev nzagorchev merged commit 26175fc into custom_inapp_templates Jun 13, 2024
1 check passed
nzagorchev added a commit that referenced this pull request Aug 6, 2024
* [MC-1465] Custom templates define (Custom Templates Part 1) (#327)

* [MC-1467] Custom templates Sync (Custom Templates Part 2) (#329)

* [MC-1466] Custom templates data in inapp notification (Custom Templates Part 3) (#330)

* [MC-1468] Custom templates present and dismiss (Custom Templates Part 4) (#332)

* [MC-1470] Custom templates actions (Custom Templates Part 5) (#336)

* [MC-1649] Custom functions allow dictionaries (Custom Templates Part 6) (#337)

* [MC-1472] In-app actions js interface (Custom Templates Part 7) (#338)

* Implement custom templates file arguments (#348)

* Add template and template context debug descriptions (#351)

* [MC-1823] Fix html view controller presented before scene became active (#352)

* tvOS compatibility (#353)

* Add SDK version as window variable to the JS interface (#354)

* Create the syncPayload and meta outside the syncWithBlock (#356)

* Expose activeContextForTemplate (#357)

* [MC-1883] File download concurrency (#358)

* Enumerate synchronously (#359)

* Update docs, Changelog and README (#360)

* Update SPM (#362)

* Bump version to 7.0.0 (#361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants