Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC-1826] tvOS compatibility #353

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

nzagorchev
Copy link
Contributor

Overview

Ensure tvOS compatibility - CleverTapSDK_TVOS target builds successfully and tvOS app builds and runs.

Implementation

  • Add CTFileDownloader and CTFileDownloadManager to the CleverTapSDK_TVOS target since PE File Variables use them
  • CTFileDownloader Remove the legacy files and preferences only if in-apps are supported (!CLEVERTAP_NO_INAPP_SUPPORT). SDWebImage is an iOS dependency only.
  • Add the FileDownload folder to the podspec tvos.source files
  • Remove CTNotificationButton from the CleverTapSDK_TVOS target since it is only used for in-apps
  • Add CTNotificationButton and CTNotificationAction to podspec tvos.exclude_files
  • Check for !CLEVERTAP_NO_INAPP_SUPPORT for CleverTap syncCustomTemplates
  • Address warnings

@nzagorchev nzagorchev changed the title tvOS compatibility [MC-1826] tvOS compatibility Jul 15, 2024
Copy link
Contributor

@nishant-clevertap nishant-clevertap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzagorchev nzagorchev merged commit 496ceff into custom_inapp_templates Jul 15, 2024
1 check passed
nzagorchev added a commit that referenced this pull request Aug 6, 2024
* [MC-1465] Custom templates define (Custom Templates Part 1) (#327)

* [MC-1467] Custom templates Sync (Custom Templates Part 2) (#329)

* [MC-1466] Custom templates data in inapp notification (Custom Templates Part 3) (#330)

* [MC-1468] Custom templates present and dismiss (Custom Templates Part 4) (#332)

* [MC-1470] Custom templates actions (Custom Templates Part 5) (#336)

* [MC-1649] Custom functions allow dictionaries (Custom Templates Part 6) (#337)

* [MC-1472] In-app actions js interface (Custom Templates Part 7) (#338)

* Implement custom templates file arguments (#348)

* Add template and template context debug descriptions (#351)

* [MC-1823] Fix html view controller presented before scene became active (#352)

* tvOS compatibility (#353)

* Add SDK version as window variable to the JS interface (#354)

* Create the syncPayload and meta outside the syncWithBlock (#356)

* Expose activeContextForTemplate (#357)

* [MC-1883] File download concurrency (#358)

* Enumerate synchronously (#359)

* Update docs, Changelog and README (#360)

* Update SPM (#362)

* Bump version to 7.0.0 (#361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants