Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Deprecated Methods #111

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Removed Deprecated Methods #111

merged 2 commits into from
Aug 31, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Aug 30, 2023 •
edited
Loading

Issues addressed by this PR

fixes #110

Test files

check that the deprecated methods are properly deleted

@Tom-Kingstone Tom-Kingstone added the status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge label Aug 30, 2023
@Tom-Kingstone Tom-Kingstone added this to the BHoM 6.3 β MVP milestone Aug 30, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Aug 30, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check documentation-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@jamesramsden-bh jamesramsden-bh added the type:compliance Non-conforming to code guidelines label Aug 30, 2023
@Tom-Kingstone Tom-Kingstone removed the status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge label Aug 30, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 34 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd self-requested a review August 31, 2023 08:25
@jamesramsden-bh
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 31, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 31, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

FraserGreenroyd
FraserGreenroyd approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning is happy, removing methods that have been marked for removal by @tg359 so good to go.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 20 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 4097db7 into develop Aug 31, 2023
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#110-RemoveDeprecatedMethods1 branch August 31, 2023 13:47
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359

@jamesramsden-bh jamesramsden-bh Awaiting requested review from jamesramsden-bh

Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 6.3 β MVP
Development

Successfully merging this pull request may close these issues.

Remove deprecated methods
3 participants
@Tom-Kingstone @jamesramsden-bh @FraserGreenroyd