Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods #110

Closed
jamesramsden-bh opened this issue Aug 29, 2023 · 0 comments · Fixed by #111
Closed

Remove deprecated methods #110

jamesramsden-bh opened this issue Aug 29, 2023 · 0 comments · Fixed by #111
Assignees
Labels
type:compliance Non-conforming to code guidelines

Comments

@jamesramsden-bh
Copy link
Contributor

Some methods have been marked with a todo to remove. Conversation with @tg359 confirmed that these can indeed be removed.

Remove these methods by adding the appropriate attributes. If a method has been replaced, then delete the old method, and add this attribute to the replacement one, e.g.

[PreviousVersion("6.3","BH.Engine.Python.Compute.IsValidEnvironmentName(System.String)")]

If the method is being removed without replacement, then we flag it for removal with the ToBeRemoved attribute, e.g.

[ToBeRemoved("6.3", "This method has been removed.")]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants