Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.3 Deployment #116

Merged
merged 23 commits into from
Sep 21, 2023
Merged

6.3 Deployment #116

merged 23 commits into from
Sep 21, 2023

Conversation

Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using BuroHappold_BHoM_6.3.230913.beta.0.msi using PythonToolkit_TestScript.gh (last updated December 15 2022) and all tests pass. (This included versioning updating components from a previous version too). 👍

Copy link

@tobyoross tobyoross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using BuroHappold_BHoM_6.3.230913.beta.0.msi using PythonToolkit_TestScript.gh and all tests pass.

Copy link

@JohannaOlin1 JohannaOlin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using BHoM_6.3.230914.beta.0.msi and PythonToolkit_TestScript.gh and all tests pass

@albinber
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 19, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 269 requests in the queue ahead of you.

@alelom alelom self-requested a review September 20, 2023 09:05
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with 230915 6.3 installer and related testing procedure

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on ETABS_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 115 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Checked by DevOps following Testing Sprint. Everything is satisfactory, DevOps clear to merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 21, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit f60a02c into main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants