6.1 Deployment #211
6.1 Deployment #211
Conversation
…ed the colour to shade 65280
|
@BHoMBot check beta-merge-status |
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 47 requests in the queue ahead of you. |
Changes made to resolve the identified issues
|
@BHoMBot check beta-merge-status |
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
|
MERGE REPORT - 2023-03-21 14:54. DETAILS: |
There was a problem hiding this comment.
Tested using BHoM_6.1.230322.beta.0 and the Environment's IES_Toolkit testing procedure using the testing procedure document 0001_IES_Toolkit.
1.0
After setting toggle to true, 1.3.1. does turn green and all panels show 'PASS' except for 1.4.2 'Push GEM file with 3 decimal points' which shows 'FAIL'. Possibly due to the c# script calling on
var rtn = new List();
for (int i = 658; i <= 681; i++)
which contains blanks, strings and natural numbers possibly causing the fail. Solution could be to alter the range selected as the updated gem file containing the location data has caused it to be 4 lines out of sync.
Changing to for (int i = 662; i <= 685; i++) results in all PASS.
However, gem files are created and when loaded into IES 2022, the model is geometrically the same as what is rendered in Rhino 7 from the JSON file. In IES 2022, the model shows nine spaces classified as 'Model' and five spaces classified as 'Local Shades'.
2.0
For the pull test, when loading the gh file and turning toggle true, the model does pull and renders into Rhino 7 successfully. When setting the ‘PullOpenings’ setting to false, model pulls without openings and with shades.
2.4.1. results in a pass.
2.4.2. results in a pass.
Testing procedure would default this as a fail 1.4.3 failed in PushTest but since it is just the testing procedure being outdated, the testing procedure will be updated and will pass.
Overall, it does pass.
There was a problem hiding this comment.
I am satisfied with the report from @CKBoulter as a final review on this pull request and am satisfied that the testing procedure has been adequate for this toolkit. I am happy to deploy this to the 6.1 beta.
There was a problem hiding this comment.
filename of the installer: BHoM_6.1.230322.beta.0 , the test procedure you followed:0001_IES_Toolkit, and an additional description of the outcome of the testing:test fail. Include details on what failed:
1.4.1: model geometrically does not look the same as the model in Rhino loaded from the JSON file
1.4.3: panel shows fail (see error message)
2.2.2 model renders in Rhino and does not look as expected
apart from all that, it's all good! ;)
|
@bhombot-ci[bot] just to let you know, I have provided a |
|
@bhombot-ci[bot] just to let you know, I have provided a |
|
@bhombot-ci[bot] just to let you know, I have provided a |
2 similar comments
|
@bhombot-ci[bot] just to let you know, I have provided a |
|
@bhombot-ci[bot] just to let you know, I have provided a |
|
@BHoMBot check compliance |
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 117 requests in the queue ahead of you. |
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 301 requests in the queue ahead of you. |
|
@BHoMBot check serialisation |
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 385 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 460 requests in the queue ahead of you. |
Bugs are with rendering in Grasshopper rather than this toolkit.
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, ready-to-merge |
|
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
IES_Toolkit
Bug
Compliance