Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening fix #208

Merged
merged 16 commits into from
Feb 3, 2023
Merged

Opening fix #208

merged 16 commits into from
Feb 3, 2023

Conversation

kprusicka
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #177

Test files

Changelog

Additional comments

@kprusicka kprusicka added the type:bug Error or unexpected behaviour label Feb 3, 2023
@kprusicka kprusicka self-assigned this Feb 3, 2023
@kprusicka
Copy link
Contributor Author

@BHoMBot Check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 3, 2023

@kprusicka to confirm, the following actions are now queued:

  • check versioning

@kprusicka
Copy link
Contributor Author

@BHoMBot Check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 3, 2023

@kprusicka to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@kprusicka
Copy link
Contributor Author

@BHoMBot Check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 3, 2023

@kprusicka to confirm, the following actions are now queued:

  • check versioning

@kprusicka
Copy link
Contributor Author

@BHoMBot Check core
@BHoMBot Check serialisation
@BHoMBot Check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 3, 2023

@kprusicka to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check null-handling

There are 2 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on review and testing with @kprusicka and @IsakNaslundBh . Approving for release to alpha

@kprusicka
Copy link
Contributor Author

@BHoMBot Check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 3, 2023

@kprusicka to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit bf77785 into develop Feb 3, 2023
@FraserGreenroyd FraserGreenroyd deleted the IES_Toolkit-#177-FixOpenings branch February 3, 2023 16:40
@kprusicka
Copy link
Contributor Author

Dziekuje @BHoMBot

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 3, 2023

@kprusicka you're very welcome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holes in floors/ceiling being reflected incorrectly on push
2 participants