Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shade colours #210

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Update shade colours #210

merged 2 commits into from
Feb 27, 2023

Conversation

EKAdebo
Copy link
Contributor

@EKAdebo EKAdebo commented Feb 24, 2023

Issues addressed by this PR

Closes #209

Changed the layer and the colour for the Shades as mentioned in the issue.

Test files

Changelog

Additional comments

@EKAdebo EKAdebo linked an issue Feb 24, 2023 that may be closed by this pull request
IES Shade Colours #209
Closed
@EKAdebo EKAdebo requested a review from kprusicka February 24, 2023 13:35
@EKAdebo
Copy link
Contributor Author

EKAdebo commented Feb 24, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 24, 2023

@EKAdebo to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 9 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Feb 27, 2023
@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Feb 27, 2023 •
edited
Loading

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

FraserGreenroyd
FraserGreenroyd approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes align with the issue described and discussed offline, happy to deploy to alphas.

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Feb 27, 2023 •
edited
Loading

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd changed the title 209 ies shade colours Update shade colours Feb 27, 2023
@FraserGreenroyd FraserGreenroyd merged commit e4859e2 into develop Feb 27, 2023
@FraserGreenroyd FraserGreenroyd deleted the 209-ies-shade-colours branch February 27, 2023 12:34
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

@kprusicka kprusicka Awaiting requested review from kprusicka

Assignees

@EKAdebo EKAdebo

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IES Shade Colours
2 participants
@EKAdebo @FraserGreenroyd