Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Cognitive Services SDK to 7.0 #9177

Merged
merged 2 commits into from Jan 10, 2020
Merged

Bump Cognitive Services SDK to 7.0 #9177

merged 2 commits into from Jan 10, 2020

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Dec 17, 2019 •
edited
Loading

@yangyuan yangyuan requested a review from erich-wang as a code owner December 17, 2019 22:13
@isra-fel isra-fel self-assigned this Dec 18, 2019
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Dec 18, 2019
isra-fel
isra-fel suggested changes Dec 23, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yangyuan , could you add a link to the swagger spec review PR in the description?
Thanks

@yangyuan
Copy link
Member Author

yangyuan commented Jan 7, 2020

Hi @isra-fel, I added one missing test.

But the CI is failing, I checked it is not related to the change. Its actually cause by other SDKs.

isra-fel
isra-fel approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@isra-fel
Copy link
Member

The failed data-plane CIs were triggered by mistake, none of data-plane code was touched. So I'll just merge the PR.

@isra-fel isra-fel merged commit 69ce7de into Azure:master Jan 10, 2020
@yangyuan yangyuan deleted the yuanyang/6_0 branch February 25, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@isra-fel isra-fel

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangyuan @isra-fel