Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 202 async support for Account operations #7944

Merged
merged 3 commits into from Dec 13, 2019
Merged

Add 202 async support for Account operations #7944

merged 3 commits into from Dec 13, 2019

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Dec 11, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 11, 2019 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 11, 2019 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10
  • ⚠️sdk/cognitiveservices/mgmt-v2016_02_01_preview [Logs]  [Release SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2016_02_01_preview/src/main/java/com/microsoft/azure/management/cognitiveservices/v2016_02_01_preview/implementation/CognitiveServicesAccountImpl.java:[115,41] withTags(java.util.Map) in com.microsoft.azure.management.cognitiveservices.v2016_02_01_preview.implementation.CognitiveServicesAccountImpl cannot override withTags(java.util.Map) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
[mvn]   overridden method is final
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-cognitiveservices: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2016_02_01_preview/src/main/java/com/microsoft/azure/management/cognitiveservices/v2016_02_01_preview/implementation/CognitiveServicesAccountImpl.java:[115,41] withTags(java.util.Map) in com.microsoft.azure.management.cognitiveservices.v2016_02_01_preview.implementation.CognitiveServicesAccountImpl cannot override withTags(java.util.Map) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
[mvn] [ERROR]   overridden method is final
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/cognitiveservices/mgmt-v2017_04_18 [Logs]  [Release SDK Changes] 
        [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysImpl.java:[25,30] cannot find symbol
[mvn]   symbol:   method checkSkuAvailabilitys()
[mvn]   location: class com.microsoft.azure.management.cognitiveservices.v2017_04_18.implementation.CognitiveServicesManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[147,29] incompatible types: java.util.List cannot be converted to java.util.List
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[148,29] incompatible types: com.microsoft.azure.management.cognitiveservices.v2017_04_18.Kind cannot be converted to java.lang.String
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-cognitiveservices: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysImpl.java:[25,30] cannot find symbol
[mvn] [ERROR]   symbol:   method checkSkuAvailabilitys()
[mvn] [ERROR]   location: class com.microsoft.azure.management.cognitiveservices.v2017_04_18.implementation.CognitiveServicesManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[147,29] incompatible types: java.util.List cannot be converted to java.util.List
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[148,29] incompatible types: com.microsoft.azure.management.cognitiveservices.v2017_04_18.Kind cannot be converted to java.lang.String
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Dec 11, 2019 •
      edited
      Loading

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10
      • ️✔️@azure/arm-cognitiveservices [Logs]  [Release SDK Changes] 
        [npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/cognitiveServicesManagementClient.js → ./dist/arm-cognitiveservices.js...
[npmPack] created ./dist/arm-cognitiveservices.js in 280ms

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Dec 11, 2019 •
      edited
      Loading

      azure-sdk-for-python - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10
      • ️✔️azure-mgmt-cognitiveservices [Logs]  [Release SDK Changes] 
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Dec 11, 2019 •
      edited
      Loading

      azure-sdk-for-net - Release

      ❌ failed [Logs] [Expand Details]
      • ❌ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10 
        [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
      • ❌Microsoft.Azure.Management.CognitiveServices [Logs]  [Release SDK Changes] 
          Failed to create the package Microsoft.Azure.Management.CognitiveServices.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=cognitiveservices /v:n /p:SkipTests=true , {}

        This was referenced Dec 11, 2019
        Closed
        Closed
        Closed
        Closed
        Closed
        @erich-wang
        Copy link
        Member

        @yangyuan , please fix the error:

         Following response status codes "202" for operation "Accounts_Delete" were
    present in the swagger spec, however they were not present in x-ms-examples.
    Please provide them

        @azuresdkci
        Copy link
        Contributor

        Can one of the admins verify this patch?

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @erich-wang erich-wang merged commit 6c03f91 into Azure:master Dec 13, 2019
        @yangyuan yangyuan mentioned this pull request Jan 7, 2020
        Merged
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Reviewers

        @erich-wang erich-wang erich-wang approved these changes

        Assignees

        @erich-wang erich-wang

        Labels
        None yet
        Projects
        None yet
        Milestone
        No milestone
        Development

        Successfully merging this pull request may close these issues.
        3 participants
        @yangyuan @erich-wang @azuresdkci